Giter Club home page Giter Club logo

musangamfure / todo-list-app Goto Github PK

View Code? Open in Web Editor NEW
22.0 22.0 3.0 1009 KB

Todo-List-App is a simple web application for creating and managing to-do lists. It allows users to create new tasks, mark tasks as completed, and delete tasks as needed. The app is built with HTML, CSS, JavaScript. Users can create new tasks, mark tasks as completed delete tasks, and edit tasks

Home Page: https://musangamfure.github.io/Todo-List-App/dist

License: MIT License

JavaScript 71.80% CSS 15.61% HTML 12.59%
checklist-application personal-organizer productivity-app reminder-app reminder-application tasktracker timemanagement todo todolist

todo-list-app's Introduction

MasterHead

Hi ๐Ÿ‘‹, I'm Emmanuel Musangamfura

A passionate full-stack software craftsman on the eternal learning journey towards (hopefully) mastery

Coding

musangamfure

musangamfure

  • ๐ŸŒฑ Iโ€™m currently learning At Microverse

  • ๐Ÿ‘ฏ Iโ€™m looking to collaborate on React and Ruby projects

  • ๐Ÿ“ I regularly write articles on https://hashnode.com/@musangamfurae

  • ๐Ÿ’ฌ Ask me about JS, React, and Ruby

  • ๐Ÿ“ซ How to reach me [email protected]

Connect with me:

@musangamfura-emmanuel-6a214a262/ musangamfure

Languages and Tools:

bootstrap css3 dart express flutter git html5 illustrator javascript linux mongodb mysql nextjs nodejs oracle postgresql rails react redux ruby sass tailwind typescript webpack xd

musangamfure

ย musangamfure

musangamfure

todo-list-app's People

Contributors

m-aminalizadeh avatar musangamfure avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

todo-list-app's Issues

Do I follow JavaScript best practices?

According to JavaScript Best Practices, DRY, KISS, YAGNI, and HTML & CSS:

Here are some issues related to JavaScript best practices:

  • The code has a mix of arrow functions and traditional functions. It is recommended to be consistent with the use of arrow functions throughout the code.
  • Redundant code: The saveTodoItems() function is called twice in the addTodo() function.
  • Unused imported module: The checkboxCheck module is imported but not used anywhere in the code
  • Code repetition: The toggleDeleteIcon function is defined twice in the code, once as an imported module and once within the same file.
  • Large functions: Some functions, such as displayTodoItems() and addTodo(), are quite large and could be refactored into smaller, more modular functions

Here are the issues related to HTML and CSS best practices:

  • Lack of semantic HTML: The code uses div and li elements without any semantic meaning, which can make the code harder to understand and maintain

code enhancement

  • would it be better to move local storage functions to the same module
  • also try to use webpack file loader to add assets direct into HTML instead of adding using JS
  • in displayTodoItems function you have to repeat the code when creating the dom element so, you can make a function to do that and call it when you want

Coding partner following JS best practices

According to JavaScript Best Practices, DRY, KISS, YAGNI, and HTML & CSS:

Here are some issues related to JavaScript best practices:

  • Use of document to access the DOM: The code uses document to access the DOM, which is not efficient and can slow down the application. A better approach would be to use a variable to store the element and then access it when needed.
  • Unclear variable names: Some of the variable names used in the code are unclear and don't follow best practices for naming conventions. For example, Add and Remove don't accurately describe what the functions do.
  • Inefficient code: The code could be made more efficient in certain areas. For example, the Display function is called multiple times, even when there is no need to update the display specifically in ClearAll. function.

The HTML code seems well-structured and follows best practices. However, here are a few suggestions:

  • Use semantic HTML tags to improve the readability and structure of the page. For example, use for the header, for the main content area,
    for the different sections, for navigation, for the footer,
  • Add alt text to the element for better accessibility.

Thanks.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.