makepkginfo on a pkg on a network volume creates a broken RestartAction key about munki HOT 5 CLOSED

From [email protected] on November 12, 2010 06:24:48

You actually get different behavior if you run makepkginfo as root. In any case, this should cause makepkginfo to fail since we don't know the actual value of RestartAction.

from munki.

From [email protected] on November 12, 2010 07:12:49

Quick fix commited as r911 , but there are a few problems that need to be addressed:

• Encoding of subprocess.Popen output needs to be handled. I hardcoded UTF-8 here, but it might be a good idea to wrap Popen in a function that actually checks what the correct encoding is.
• Popen is called in a lot of places without checking the returncode.
• Error handling in munki is very fragmented. Sometimes exceptions are raised, and sometimes None, -1, or False is returned. I think returning None is the correct option here, but I can't be sure.

from munki.

From [email protected] on November 12, 2010 08:28:59

"* Encoding of subprocess.Popen output needs to be handled. I hardcoded UTF-8 here, but it might be a good idea to wrap Popen in a function that actually checks what the correct encoding is."

My ignorance is showing here -- I have no idea what would be involved here.

"* Popen is called in a lot of places without checking the returncode.

• Error handling in munki is very fragmented. Sometimes exceptions are raised, and sometimes None, -1, or False is returned."

All true. Patches welcome to clean things up.

from munki.

From [email protected] on November 12, 2010 09:57:01

I think

out, err = [s.decode(locale.getpreferredencoding()) for s in proc.communicate()]

does the trick. This would require testing on a lot of different locales, so maybe it's a good idea to wait until after the release of 0.7.0.

As for error handling, I'm afraid I'd break more than I'd fix.

from munki.

From [email protected] on December 02, 2010 13:43:53

Marking as fixed because the primary issue as been addressed. We can open a general unicode issue if needed to address the the remaining issues

Status: Fixed

from munki.