Giter Club home page Giter Club logo

Comments (7)

natewalck avatar natewalck commented on July 22, 2024

The receipts look correct in the package itself and the package name looks right in the release page. Where do you see the build number as 482?

Screenshot 2023-07-06 at 20 33 15

from munki.

arubdesu avatar arubdesu commented on July 22, 2024

I'm assuming this is the carry over from googlecode/svn's incrementing, but... dunno how it would break

from munki.

xndr avatar xndr commented on July 22, 2024

In munki/code/tools/make_munki_mpkg.sh, MAGICNUMBER=482, and it used to match the build number before? This is also reflected the the .pkg filename produced by the latest release.

from munki.

natewalck avatar natewalck commented on July 22, 2024

That number never matched the build number since this moved to git. Check the git history for the history on that file specifically.

It's the offset from when we switched from SVN to git so the build numbers in git would be at the correct number.

from munki.

xndr avatar xndr commented on July 22, 2024

In the source tarball release for 6.3.1, MAGICNUMBER=4581, and in the source tarball for 6.3.2, MAGICNUMBER=482.
When I run make_munki_mpkg.sh for both these releases, it gives me the file names munkitools-6.3.1.4581.pkg and munkitools-6.3.2.482.pkg

Ultimately, I suppose it doesn't really matter. I just thought it might have been a typo so I thought I'd raise the issue.

from munki.

gregneagle avatar gregneagle commented on July 22, 2024

Are you doing a shallow git clone or no git clone and just downloading the zip file? In either case the "calculated" build number will be wrong.

https://github.com/munki/munki/wiki/Building-Munki-packages#procedure

Since you mention "In the source tarball release for 6.3.1" I'm guessing you aren't using a full git clone. Thus your odd/wrong build number.

from munki.

gregneagle avatar gregneagle commented on July 22, 2024

No response, but I think my guess is right, so closing this.

from munki.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.