Apple Update list has blank list items under non-english 10.5 systems about munki HOT 11 CLOSED

From [email protected] on September 02, 2010 09:38:30

I'll probably need some help on this; English is the only language value that shows up for me in the dist files, so it's hard for me to test other languages. I'm actually surprised that language localization issues haven't come up before now...

Status: Accepted

from munki.

From vongablersahm on September 02, 2010 11:15:23

I am not sure how the language for the updates catalog is selected. I would guess it is taken from the language the loginwindow has been set to. Individual users could have different language settings for their session, but munki's software update runs as root and has no easy way to know the current user's language - or even adapt to it.

You can probably reproduce the problem by using /usr/sbin/languagesetup on a 10.5 system to temporarily switch languages.

Attached is an example dist file with german localization:
/Library/Updates/Java für Mac OS X 10.5 Update 5/Java für Mac OS X 10.5 Update 5.dist

from munki.

From [email protected] on September 02, 2010 12:08:01

I can't seem to force any language other than English. But maybe we don't have to care, and can just grab the first localized string regardless of language. Can you try the attached file as a replacement for appleupdates.py?

Status: Started
Owner: [email protected]

from munki.

From vongablersahm on September 02, 2010 13:20:51

That works great, the update titles are being parsed correctly.

One little thing: The description for "Java für Mac OS X 10.5 Update 7" does show some spurious lines before the real description. All other updates do show up correctly.

I have attached the two sample files.

from munki.

From [email protected] on September 02, 2010 14:48:09

appleupdates.py attempts to parse the dist file to get the HTML description, but there are various formats and sometimes it grabs the wrong thing. In the case you mention, the localization contains two things labeled SU_DESCRIPTION. parseDist just grabs everything after the first SU_DESCRIPTION tag. If there's more than one, I'm not sure how parseDist can decide which one is the right one...

from munki.

From [email protected] on September 02, 2010 16:23:05

Try this new appleupdates.py to see if it does a better job of parsing the dist file description.

from munki.

From vongablersahm on September 02, 2010 22:49:54

The new appleupdates.py does not change the display of the descriptions, as far as i see. The AppleUpdates.plist remainy identical.

But it looks like the duplicate SU_DESCRIPTION tags are a localization error on Apple's part. You could only try to behave like the SoftwareUpdate.app and always display the last SU_DESCRIPTION there is. Or prefer a SU_DESCRIPTION beginning with "", but that seems like overkill.

from munki.

From [email protected] on September 03, 2010 06:37:19

"You could only try to behave like the SoftwareUpdate.app and always display the last SU_DESCRIPTION there is."

The correct one is the last on in this particular case, but there's no guarantee it will always be the correct one.

"Or prefer a SU_DESCRIPTION beginning with "", but that seems like overkill."

They don't always start with an tag...

from munki.

From [email protected] on September 03, 2010 14:48:22

Try this attached version of appleupdates.py!

from munki.

From vongablersahm on September 03, 2010 15:41:03

works perfectly!

from munki.

From [email protected] on September 03, 2010 15:43:04

Great. Marking as fixed.

Status: Fixed

from munki.