munin-monitoring / munin-plugin-gallery Goto Github PK

Currently the pages of taxonomies and terms are retrieved in a quite hackish way (or similar):

{{ with $.Site.GetPage (printf "/%s/" $taxonomy_name) }}

Instead we should access the .Site.Taxonomies for retrieving taxonomy and term objects.

Currently some reverse URL lookups fail to work (e.g. the ones containing special characters).

h

Source: https://salsa.debian.org/ci-team/debci/-/tree/master/munin/plugins

Name: debci_
Modules:

• debci_containers
• debci_packages_being_processed
• debci_packages_processed
• debci_queue_size
• debci_total_packages_processed

Some plugins in the munin repository have the same name:

$ find plugins/ -name cpu.in
plugins/node.d.netbsd/cpu.in
plugins/node.d.linux/cpu.in
plugins/node.d.freebsd/cpu.in
plugins/node.d.sunos/cpu.in
plugins/node.d.aix/cpu.in

Only one of these plugins (maybe even a random one) is the final plugin to be presented in the plugin gallery.

Instead the generator should detect duplicate names and try to add a unique token based on the distinct part of the filename's path (e.g. cpu (linux) or linux/cpu).

Looking at the plugin: process_group
Its home/source is: https://github.com/munin-monitoring/contrib/blob/master/plugins/cpu/process_group

Which is a valid plugin:

$ munin-get search process_group
contrib/process_group                  2023-12-12

It was first created on 2023-12-11.

Now trying to go to: https://gallery.munin-monitoring.org/plugins/munin-contrib/process_group/, gives a 404.

Searching process_group and process-group gives 0 results.

This repo had its last commit 3 years ago...

Three minor issues I encountered when using this the other day:

• there is no indicator that the search has been accepted; when you type something in, there is a delay and then the sidebar updates to show the results
• ...unless there are no results, in which case nothing happens, so there's no way to distinguish between "search still running" and "search completed and returned the empty set"
• if you don't realize the above and think you need to press enter to search, it reloads the same page with your search cleared and ? appended to the URL

Search still works, but this isn't great UX.

Suggested mitigations:

• display a visible indicator when the search is running
• display "no results" or similar if the search finds nothing
• make enter in the search box a no-op

The landing page could end with a list of most recently updated plugins (probably without pagination). This would let it look a bit more lively (fresh dates are visible for visitors) and it would allow people to stumble upon random plugins.

Some statistics could be included in the landing page or in a separate page.

These statistics could include:

• number of plugins per repository
• number of example graphs
• number of plugins by language

It would be good to simplify contributions by adding and edit button to each plugin (e.g. to the plugin details box).

This would probably require a platform-specific URL pattern (e.g. for github) to be defined in config.yml.