Make CC dependency a (default?) feature about rust-multihash HOT 7 CLOSED

but people could list out the algorithms they need and the others would be excluded.

This is what tiny-multihash is doing (which is what likely will go upstream). Though for now I'd just restrict it to blake3 to unblock @thenextman.

from rust-multihash.

@mriise do you have time to work on making it optional? If not, then I can work on it some time the next few days. I just want to prevent double efforts.

@vmx I'll see what i can do, as i'm not terribly familiar with macros.
As a side note, (and from what i currently understand about macros) it would be easy to setup each algorithm (or family) as its own feature, with the default being all, but people could list out the algorithms they need and the others would be excluded.
although that may be just be unneeded feature bloat.

from rust-multihash.

Are you asking more to have blake3 be an optional feature, or to have specific CC dependencies as the title suggests?

I'm willing to make another PR to setup blake3 as an optional dependency but would prefer to wait to see where the rewrite is headed and work from there.

from rust-multihash.

@mriise The rewrite still takes a while (as I'm too busy with other things). I like your idea of having blake3 as an optional feature, that should unblock @thenextman. I could do a v0.11.4 release with it.

from rust-multihash.

@mriise Having blake3 as an optional feature would unblock things for us and be appreciated, like @vmx said. Ultimately, we can't build C "on the fly" like that - I would expect the same is true for anyone building cross-platform C projects of certain complexity, because there's no "one size fits all" with build processes and compilation options. Sorry if my issue title was not very clear :)

from rust-multihash.

@mriise do you have time to work on making it optional? If not, then I can work on it some time the next few days. I just want to prevent double efforts.

from rust-multihash.

As a side note,
It bothered me that Blake3 was trying to compile C in the first place, after a bit more looking around, it turns out you can force the rust only implementation by using the "pure" feature.

from rust-multihash.