multiformats / go-multiaddr-dns Goto Github PK

View Code? Open in Web Editor NEW

28.0 19.0 18.0 1.11 MB

Go library and CLI tool for /dns4, /dns6, /dnsaddr multiaddr resolution

Home Page: https://multiformats.io/multiaddr

License: MIT License

Go 100.00%

dns multiaddr dnsaddr resolve madns

go-multiaddr-dns's People

Stargazers

Watchers

Forkers

sysbot dms3-mft overbool dalavancloud jonnycrunch jayd2446 cnxtech thexdesk steamraven jorropo ljoez isabella232 jeff-bouchard iowaguy

go-multiaddr-dns's Issues

Add caching to default resolver

IIRC, normally the code will use the default net.DefaultResolver and has no caching layer.

Make a proper madns CLI

Add DNS Cache that respects TTL of resolved DNS records

Problem

When DNS over HTTPS resolver is set up, every query produces HTTP request.

To illustrate, when using https://resolver.cloudflare-eth.com/dns-query for crypto TLDs, this adds around 1 second to EVERY resolution event (only the very first one should be that slow):

$ t ipfs name resolve /ipns/brave.crypto
/ipfs/QmWrdNJWMbvRxxzLhojVKaBDswS4KNVM7LvjsN7QbDrvka
  0.25s user 0.03s system 21% cpu 1.274 total

$ t ipfs name resolve /ipns/brave.crypto                                                                                                                                                    /ipfs/QmWrdNJWMbvRxxzLhojVKaBDswS4KNVM7LvjsN7QbDrvka
  0.21s user 0.02s system 20% cpu 1.100 total

$ t ipfs name resolve /ipns/brave.crypto                                                                                                                                                   
/ipfs/QmWrdNJWMbvRxxzLhojVKaBDswS4KNVM7LvjsN7QbDrvka
  0.23s user 0.02s system 23% cpu 1.058 total

To illustrate, using non-DoH name leverages OS-level resolver as a cache, and only first lookup is expensive:

$ t ipfs name resolve /ipns/en.wikipedia-on-ipfs.org                                                                                                                                        
/ipfs/bafybeiaysi4s6lnjev27ln5icwm6tueaw2vdykrtjkwiphwekaywqhcjze
  0.23s user 0.05s system 80% cpu 0.343 total

$ t ipfs name resolve /ipns/en.wikipedia-on-ipfs.org                                                                                                                                        /ipfs/bafybeiaysi4s6lnjev27ln5icwm6tueaw2vdykrtjkwiphwekaywqhcjze
  0.04s user 0.01s system 173% cpu 0.029 total

$ t ipfs name resolve /ipns/en.wikipedia-on-ipfs.org                                                                                                                                        /ipfs/bafybeiaysi4s6lnjev27ln5icwm6tueaw2vdykrtjkwiphwekaywqhcjze
  0.03s user 0.02s system 160% cpu 0.032 total

Solution

The problem is not limited to DoH – there is no point in hitting OS-level default resolver if we could use cached record.
We need to add a global DNS Cache to resolve.go that makes sure we don't do redundant lookups until TTL from resolved record expires.

cc @aschmahmann @vyzo what would be the least painful way to solve this globally?

dnsaddr code?

The code for dnsaddr is not consistent.

go uses code 12345
js uses code 53
protocols.csv does not mention dnsaddr but has a dns at code 53.

Can someone please clarify! cc: @diasdavid @whyrusleeping

Support and test /dns/

It seems that this library supports /dns4 and /dns6 but does not support /dns

Given that

JS multiformats/js-multiaddr#253 is adding support for /dns/
and it is a valid code present in both multiaddr/protocols.csv and multicodec/table.csv

i think we should add it here as well.

Resolution order

Reuse prior art from https://en.wikipedia.org/wiki/Happy_Eyeballs ?

Make Readme good

End-to-end and CLI tests

Should be able to:

plug in a local DNS server/resolver
can use a different madns executable (e.g. js?)

Filtering by protocol stack

The -p on the CLI filters results by protocol stack. Not sure yet what the interface around Resolve() should be.

> madns -p /ip6/tcp/wss /dnsaddr/example.net
/ip6/2001:db8::a3/tcp/443/wss/ipfs/Qmfoo
/ip6/2001:db8::a4/tcp/443/wss/ipfs/Qmbar

multiformats / go-multiaddr-dns Goto Github PK

go-multiaddr-dns's People

Stargazers

Watchers

Forkers

go-multiaddr-dns's Issues

Add caching to default resolver

Make a proper madns CLI

Add DNS Cache that respects TTL of resolved DNS records

Problem

Solution

dnsaddr code?

Support and test /dns/

Resolution order

Make Readme good

End-to-end and CLI tests

Filtering by protocol stack

Interface unit tests and fuzzing

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent