The cs-multiaddress from multiformats

cs-multiaddress's People

Stargazers

Watchers

cs-multiaddress's Issues

P2P code is 421 and not 420

If you look in this file https://github.com/multiformats/go-multiaddr/blob/master/protocols.go you can see P2P have the same code than IPFS. IPFS is after for backwards compatibility. In this repo P2P is with 420 code and IPFS with 421 code.

	P_P2P               = 0x01A5
	P_IPFS              = 0x01A5 // alias for backwards compatability

Having the possibility to add new protocols

I need to add new protocol in multi address.

In the projet go-threads they have a new protocol "thread" with this properties.

const (
	// Name is the protocol slug.
	Name = "thread"
	// Code is the protocol code.
	Code = 406
	// Version is the current protocol version.
	Version = "0.0.1"
	// Protocol is the threads protocol tag.
	Protocol protocol.ID = "/" + Name + "/" + Version
)

I've created a new class "Thread" derived from MultiaddressProtocol but I can't add it to Multibase. Methods are private.

namespace Textile.Threads.Core.Protocols
{
    public class Thread : MultiaddressProtocol
    {
        static Thread()
        {
            
        }
        public Thread() : base("thread", 406, -1)
        {
           
        }

        public override void Decode(string value) => Value = Multibase.Decode(value, out MultibaseEncoding _);
        public override void Decode(byte[] bytes) => Value = bytes;
        public override byte[] ToBytes() => (byte[])Value; 
        public override string ToString() => Multibase.Encode(MultibaseEncoding.Base32Lower, (byte[])Value);
    }
}

Recommend Projects