multiformats / c-multihash Goto Github PK

The latest discussion about this subject:

http://thread.gmane.org/gmane.comp.version-control.git/299687/

There have been many other discussions about this over the years, but the latest one above is a good starting point. It mentions multihash.

I have noticed that go-multihash provides additional functionality that c-multihash (and other implementations) do not. This additional functionality appears to be dependended upon by reverse dependencies of go-multihash, such as go-ipld, go-ipfs and go-libp2p.

I also notice a discrepancy between the functionality of go-multihash and js-multihash in that there is functionality provided by js-multihash, which is depended upon by its reverse dependencies, which is not provided by go-multihash.

Here is a list of some of the multihash dependencies that do not seem to be supported by c-multihash:

Language: golang

repo: go-libp2p
file: /p2p/protocol/relay/relay.go
multihash dependencies:
NewReader()
NewWriter()
Multihash()

repo: go-ipld
file: ipld.go
multihash dependencies:
FromB58String()

repo: go-ipfs
file: /namesys/routing.go
multihash dependencies:
FromB58String()
Cast()

repo: js-ipfs
file:/src/core/components/block.js
multihash dependencies:
FromB58String()
file: /src/core/components/files.js
multihash dependencies:
toB58String()
file: /src/core/components/init.js
multihash dependencies:
toB58String()

My question is, would pull requests to c-multihash be welcome which implemented this functionality?

cc @RichardLitt

Would be good to have more than to dos, here.