mui / tech-challenge-react Goto Github PK

This challenge was created based on a version of the code released in January 2021. So this challenge is now 3 years old. Time to resync it with the main repository. This was first suggested in #17.

Problem

• Potential issue https://app.ashbyhq.com/candidate-searches/new/right-side/candidates/9accc4ca-4d6c-4410-89b8-637aa9158a9a/applications/77ed8b92-be26-46c3-8a3b-0e1b888bec2f/notes

I was doing the challenge a few hours ago when this error came up (only while running the test)

After spending a lot of time troubleshooting, I found out that the root cause was a CSS file that I had put in the component folder next to the tsx file.

Now, I am not sure whether this is a known issue or a quirk of the testing library -- or that I was wrong to think that putting a CSS file like that is still allowed in the current Next version. I still think that it would be helpful to address this somewhere in the README.md file. The error it threw made it even more confusing.

ps. the error is different from this module issue #11

It might not work, because of the version of sharp/Next.js/playwright installed.

Next.js allows people to import css modules (.module.css) files to author their styling. However, the tests break on these imports. We may want to support css modules out of the box to level the playingfield for people that assume it's fine to use css because the docs application supports it.

Because we are using Next.js v10, candidates can't use Node.js v18 or later. The current workaround for them is to do:

diff --git a/docs/package.json b/docs/package.json
index 916e7c3..37b07ef 100644
--- a/docs/package.json
+++ b/docs/package.json
@@ -8,7 +8,7 @@
     "build": "cross-env NODE_ENV=production next build --profile",
     "build:clean": "rimraf .next && yarn build",
     "build-sw": "node ./scripts/buildServiceWorker.js",
-    "dev": "rimraf ./node_modules/.cache/babel-loader && next dev --port 3002",
+    "dev": "rimraf ./node_modules/.cache/babel-loader && NODE_OPTIONS=--openssl-legacy-provider next dev --port 3002",
     "deploy": "git push material-ui-docs next:next",
     "export": "rimraf docs/export && next export --threads=3 -o export && yarn build-sw",
     "icons": "rimraf public/static/icons/* && node ./scripts/buildIcons.js",

Going forward, we might have to recreate the whole https://github.com/mui/react-technical-challenge repository using the latest version of http://github.com/mui/material-ui.