Comments (4)
I agree with the general sentiments here. This particular example is an extreme case though and we should mention such cases in our docs. In this case, it might be beneficial to just use inline style with a css variable so that the generated style doesn't need to change with each change in the value.
We might have to take a perf for such similar cases and weed out actual issue as I also think it might not always be related to the dynamic values (unless the value here changes at the decimal level as well instead of whole numbers 1-100).
cc: @mnajdova Your thoughts here ?
from material-ui.
Docs improvements up for review #42239
from material-ui.
use inline style with a css variable so that the generated style doesn't need to change with each change in the value.
This is what I would propose too. I remember similar issues in the past: #36749, #36294. @aarongarciah would you be up to updating the docs to include this information?
from material-ui.
@mnajdova I'll do it 👍
from material-ui.
Related Issues (20)
- [Popover] Popover does not lock the scroll on mobile. HOT 1
- [Popover] function for `slotProps.paper` isn't working HOT 3
- React multiple select dropdown with checkboxes, when open, has critical and serious accessibility errors.
- [material-ui][Popover] The `disableScrollLock` prop is causing issues with CSS and additional scrolling functionality HOT 6
- [docs-infra] Refine how subheaders are shown in the page body
- disableScrollLock doesn't work for Select when wrapper's overflow=hidden
- [icons] Material Icons do not support Joy UI's "danger" color prop
- Minimizing bundle using 'babel-plugin-import' results in 'Cant Resolve...' errors
- The text field label and helper text flicker and change color when another text field is focused.
- ThemeOptions Ownerstate for MuiOutlinedInput does not contain correct values
- Autocomplete resizes on hover/focus when displayed in a table with table-layout: auto set
- Cannot change displayedRows child component from <p> to <div> HOT 1
- [system] `sx` field border{Block,Inline}{,Start,End}Color doesn't take the theme into account
- Bad link for Rating component to react docs.
- [TextField] Textfield as a Select shows an empty menu when items get removed dynamically
- [lab][TabPanel] Widen type of `value` to match `@mui/base` TabPanel and related components HOT 2
- [material-ui][Divider] Add "wavy" variant HOT 1
- [Migration] theme.spacing is not a function HOT 1
- Stepper does not generate a utility class for nonLinear HOT 2
- [docs-infra] JSDoc links are broken HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from material-ui.