mubn / ansible-mail-server Goto Github PK

Hello,
thank you for your work, this has taken a lot of work off my hands.

I had problems with the Catch-All alias. In the original version there is the alias table. A null for the source_username stands for "Forward all mails that cannot be mapped to destination". This does not work or me. Maybe this should not work for security reasons. But if it should work is here what I changed:

The schema for the alias table is located at roles/mariadb/files/schema.sql and has

CREATE TABLE `aliases` (
...
    `source_username` varchar(64) NOT NULL,
...
);

The fix is to allow the source_username to be NULL

There is also a query in roles/postfix/templates/sql/aliases.jq:

select concat(destination_username, '@', destination_domain) as destinations from aliases where source_username = '%u' and source_domain = '%d' and enabled = true;

I used the original query

SELECT DISTINCT concat(destination_username, '@', destination_domain) AS destinations FROM aliases
        WHERE (source_username = '%u' OR source_username IS NULL) AND source_domain = '%d'
        AND enabled = true
        AND NOT EXISTS (SELECT id FROM accounts WHERE username = '%u' and domain = '%d');

After this changes, Catch-All Support works for me, but the mailserver is not in production use. So maybe this fix creates some side effects.

Please check the fix and if this is good, it can be adopted.

If it's not good, or makes a security hole possible, feel free to tell me why.

I have this error:
fatal: [172.xxx.xxx.xxx]: FAILED! => {"cache_update_time": 1628087767, "cache_updated": true, "changed": false, "msg": "'/usr/bin/apt-get -y -o "Dpkg::Options::=--force-confdef" -o "Dpkg::Options::=--force-confold" install 'rspamd' 'redis-server'' failed: E: Unable to correct problems, you have held broken packages.\n", "rc": 100, "stderr": "E: Unable to correct problems, you have held broken packages.\n", "stderr_lines": ["E: Unable to correct problems, you have held broken packages."], "stdout": "Reading package lists...\nBuilding dependency tree...\nReading state information...\nSome packages could not be installed. This may mean that you have\nrequested an impossible situation or if you are using the unstable\ndistribution that some required packages have not yet been created\nor been moved out of Incoming.\nThe following information may help to resolve the situation:\n\nThe following packages have unmet dependencies:\n rspamd : Depends: libicu57 (>= 57.1-1~) but it is not installable\n Depends: libsodium18 (>= 0.6.1) but it is not installable\n", "stdout_lines": ["Reading package lists...", "Building dependency tree...", "Reading state information...", "Some packages could not be installed. This may mean that you have", "requested an impossible situation or if you are using the unstable", "distribution that some required packages have not yet been created", "or been moved out of Incoming.", "The following information may help to resolve the situation:", "", "The following packages have unmet dependencies:", " rspamd : Depends: libicu57 (>= 57.1-1~) but it is not installable", " Depends: libsodium18 (>= 0.6.1) but it is not installable"]}

i dont want to install certbot, please can you give a hint for this error