Giter Club home page Giter Club logo

Comments (5)

zwirektech avatar zwirektech commented on August 15, 2024 3

I'd like to share my view on this issue.
Last year I've started my journey with git. I'm a user, not a coder, but I always try to do things right. I've read manual, tutorials, etc. I've spent hours reading, learning and testing it on my local debian. Finaly I've come here.
It was one of the biggest disappointments ever when I've made my first PR and... nothing happend. I've waited an hour, two hours and nothing happend yet...
When you are excited with your learnig progress, you are eager to go on, it is like getting a flat tire...
Today of course I understand how It works, but at that time the workflow which is behind all these commits wasn't clear.
I think most of these dead PRs may have the same source. Someone wanted to do something... but gave up because of time delay or additional requirements to the commits he/she has done. Believe me, it is not that clear at the begining that someone has to review such a PR and what logic is in the git workflow.

I'm sorry that I don't give you a good solution here, but I think most people already working with git may not realize the beginner's confusion. Perhaps making the required tasks as simple as possible would be a good idea.

I'd like to thank you all @muan @aaossa @SubhrajyotiSen for the job you have done to help me understand the basics of git.
Especially @SubhrajyotiSen for the detailed comment on my first PR.

from hello-world.

muan avatar muan commented on August 15, 2024 3

I think one month is reasonable time. We can add a bot to close stale PRs after one month.

At the same time I think it might be worth doing another ping perhaps 2 weeks after the initial request change. Again we might be able to use a bot to do this. Bot can comment with something friendly like

Looks like a maintainer has requested change on your pull request. Now we need you to make some changes so we can review this pull request again. These links might be helpful:

- [What's my branch]()
- [How to make changes on a branch]()
...

Please feel free to comment if the requested changes weren't clear or if you need help to proceed.

Thanks @aaossa @SubhrajyotiSen for your continued work on this repo! I'll clear out some of the issues that are waiting on me asap. 🙇‍♀️

from hello-world.

SubhrajyotiSen avatar SubhrajyotiSen commented on August 15, 2024

One month seems like a fair enough time

from hello-world.

aaossa avatar aaossa commented on August 15, 2024

That sounds good to me 🙌 Is there any simple service to create that bot or should we create a custom one? I'm gonna try to find some possible solutions. Should we ping the current "dead PRs" manually in the meantime?

from hello-world.

SubhrajyotiSen avatar SubhrajyotiSen commented on August 15, 2024

I will try making the bot once I get some free time.

from hello-world.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.