wasm-android-demo's People
Forkers
njuwangchen kenrussell moonight10 zhiqiangyu skyrookieyu therahulkanyal binadamu-isiyoonekana jahentao gmh5225wasm-android-demo's Issues
rename com.sample namespace to just moreteapots
The word "sample" is confusing/redundant
sylvester.js
What's this file? is it autogen-ed? if yes, please remove it.
MoreTeapotsRenderer.cpp
Instead of the many #if checks, consider an alternative for ensuring exactly only one option is enabled. You could sum up the presence of each option, and ensure it adds up to 1, for instance.
Build is broken; gradle-wrapper.jar was removed with no explanation
In #28 gradle-wrapper.jar was inexplicably removed from the workspace. This breaks step 2 of the Android build; the "gradlew" script puts it on the CLASSPATH.
Checking out 4efa6c6 allows the build to proceed a bit further, but there are hardcoded paths in some of the build files (local.properties, in particular).
teapot_triangle.inl
Remove all commented code lines/regions (e.g. 23, 39->down)
MoreTeapotsNativeActivity.cpp - please remove commented code
Verify all functionality on the jni side is needed
https://github.com/mtrofin/wasm-android-demo/tree/master/app/src/main/jni
There is support for pinching, dragging, etc. Do we need that?
gl3stub.h
https://github.com/mtrofin/wasm-android-demo/blob/master/app/src/main/common/gl3stub.h#L69
doesn't this belong in an android-specific file?
teapot.inl
emsMain.cpp
https://github.com/mtrofin/wasm-android-demo/blob/master/app/src/main/wasm/emsMain.cpp#L66
remove comment
also, why "emsMain.cpp" - could we rename it to "MoreTeapots-wasm.cpp" or something like that?
MoreTeapotsRenderer.h
webgl - vertex definitions
Do we have duplicate teapot vertex definitions, e.g. apple-to-apple.js and then also within teapots.js? Do we need them all?
shader.h
https://github.com/mtrofin/wasm-android-demo/blob/master/app/src/main/common/shader.h#L27
Does having this namespace make sense anymore?
MoreTeapotsApplication.java
webgl - vertex definitions
Do we have duplicate teapot vertex definitions, e.g. apple-to-apple.js and then also within teapots.js? Do we need them all?
Move the java and jni folders under an android folder
as the title suggests - that way, all android stuff is under one folder. The fact that it's split in c/c++ and java is relevant to android, not to the overall architecture of the cross-targeting application.
What were the findings?
Hello, the README says
The project has two goals. The first one is to evaluate the engineering cost of porting an Android application to WASM. The other one is trying to figure out the performance overhead of WASM, compared to native Androis apps.
Curious to know what were the findings.
teapot_zeros.inl
Remove comments
remove NDKHelper.java
remove this folder and contents:
https://github.com/mtrofin/wasm-android-demo/tree/master/app/src/main/java/com/sample/helper
teapot_zeros.inl
Remove comments
centralize vertex definitions
instead of having 2 copies of the vertex definitions for teapots (one in the .inl file under common, and one in apple-to-apple.js), could we have a file in common with the list of values? Then, the native side could #include that file, and the javascript side could be either generated using the C-preprocessor, or you could load and parse the list at the web app startup time, and form the vertex arrays that way.
Remove build folder and contents
Also, please ensure build artifacts are .git ignored.
Is nativeactivity needed?
This refers to the folder in the root of the repository. Is this still necessary after the recent refactoring?
vecmath.h
Do we need graddle.wrapper
Is this an external dependency, or is it built? Can we remove it from the repo and obtain it differently?
webgl-demo.js
Move the res folder under common (assuming it's all common)
webgl
rename "apple-to-apple.js" to teapot.js or teapot-vertices.js
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.