mtj0928 / resizablesheet Goto Github PK

Thank you for open source. I think ResizableSheet is a more SwiftUI way implementation.
But when I add Multi-line Text in builder.content, the scrollView's content size is incorrect.

It seems the sheet always needs medium then close. How to Large -> hidden?

Hola. Thanks for provide the community with such an elegant sheet. No major issues, just something I've noticed.

The sheet's background changes when the system's theme changes: dark mode gives the sheet a dark color and light mode... white sheet. Apps can specify a theme in which the sheet does not respect. An example how an app could change the theme:

class Utilities: ObservableObject {

    // The default is to use the system's default.
    @AppStorage("theme") var theme: String = ""
    
    var userInterfaceStyle: ColorScheme? = .dark

    func overrideDisplayMode() {
        var userInterfaceStyle: UIUserInterfaceStyle

        if theme == "On" {
            userInterfaceStyle = .dark
        } else if theme == "Off" {
            userInterfaceStyle = .light
        } else {
            userInterfaceStyle = .unspecified
        }
        
        let scenes = UIApplication.shared.connectedScenes
        let windowScene = scenes.first as? UIWindowScene
        let window = windowScene?.windows.first
        
        window?.overrideUserInterfaceStyle = userInterfaceStyle
    }
}

Should the system is set to dark mode and the app to light, the content sheet's background is still dark. Ok I could use the .sheetBackground modifier you've provided us, with a combination with @Environment(\.colorScheme) var colorScheme. Seems a bit messy if we have many sheets within the app. Is there a way to make the sheet respect the app's theme? I'd rather not having to keep repeating this:

view.resizableSheet($state) { builder in
            builder.content { context in
                VStack {
                    Text("Demo")
                    Spacer()
                }
                    .padding()
                    .frame(height: 300)
            }.sheetBackground { _ in
                Color(colorScheme == .light ? "custom-white" : "custom-secondary")
            }
        }

Unfortunately I couldn't even present a simple Text("text") based on your documents in a timely manner.

Simple example project would've been very helpful

I will introduce SwiftLint

I will introduce GitHub Actions after #7.