msteffen / pachyderm-tools Goto Github PK

currently the config is in '$HOME/.svpconfig' but the directory in the title seems to be more canonical for unix tools (direnv, gcloud, gedit, gocode, chrome, nautilus, unity, etc :-) )

The rest of the team already uses direnv for customer work, and I've essentially duplicated the functionality in this tool

Example:

$ svp diff --branch=origin/prev-change
could not run command (command: "git show origin/prev-change:src/client/pkg/version/version.go"):
fatal: Path 'src/client/pkg/version/version.go' exists on disk, but not in 'origin/prev-change'.

(exit status 128)

No error message—this is just a guess based on having read the code and not having seen this case handled. I believe that changedFiles() either doesn't return deleted files, or the syntax passed to the diff command is something like :src_server_my_code (with no left-side diff), which wouldn't make sense

Example:

$ cd ~/clients/add-dbg-to-vault-plugin/src/github.com/pachyderm/pachyderm/src/plugin/vault
$ svp diff vault_test.go 
file "/home/mjs/clients/add-dbg-to-vault-plugin/src/github.com/pachyderm/pachyderm/vault_test.go" does not exist

The problem is that the plugin is looking for vault_test.go at:

${GOPATH}/src/github.com/pachyderm/pachyderm/vault_test.go

but it should be looking at

${GOPATH}/src/github.com/pachyderm/pachyderm/src/plugin/vault/vault_test.go

I tried implementing this once (in the client-directory-env-vars branch) and ran into the issue that if a client is created in a directory defined with an env var (e.g. ${HOME}/clients) then all the environment variables in that client's .envrc should use the expanded environment variable: if ${HOME} is /home/a and I create a client in /home/a/clients/c and then change ${HOME} to /home/b, I don't want ${GOPATH} in /home/a/clients/c to suddenly by /home/b/clients/c which may not even exist.

If I do allow env vars in client_directory, they should be resolved before the client is created, and not used for anything except new-client. For now, I'm leaving the branch in this repo but abandoning the feature