mstefarov / fcraft Goto Github PK

It gets stuck in 'Resolving external point'. This is due to this line:

IPEndPoint BindIPEndPointCallback( ServicePoint servicePoint, IPEndPoint remoteEndPoint,
    int retryCount ) {
        return new IPEndPoint( InternalIP, 0 );
}

InternalIP is an ipv4 address, so it ends up looping 2,147,483,647 times. However, because I have IPv6, it is using an ipv6 socket to connect to fcraft.net's IP check uri.

The simple fix is to do this instead: https://github.com/123DMWM/ProCraft/blob/b2ed46e61c9d533c421c85ef859cec8a94979f8e/fCraft/System/Server.cs#L1236

To also ensure that the external IP shown is the IPv4 address, you can prefer ipv4 connections with this https://github.com/123DMWM/ProCraft/blob/b2ed46e61c9d533c421c85ef859cec8a94979f8e/fCraft/System/Utils/HttpUtil.cs

public int CompareTo( Vector3I other ) {
      return Math.Sign( LengthSquared - LengthSquared );
}

public int CompareTo( Vector3F other ) {
      return Math.Sign( LengthSquared - LengthSquared );
}

Guessing you meant other.LengthSquared the second time?