Giter Club home page Giter Club logo

Comments (12)

msberends avatar msberends commented on August 27, 2024 1

No, just do:

remotes::install_github("msberends/AMR")

It will install the latest beta version to your computer and then you can just run your code again (you might need to refresh your R session). But this issue is not yet fixed, I'm now also fixing your other issue in one go 🙂

from amr.

antunderwood avatar antunderwood commented on August 27, 2024

In addition looking at the https://github.com/msberends/AMR/blob/master/data-raw/DRGLST1.xlsx table I think the values here are for animals
image

from amr.

antunderwood avatar antunderwood commented on August 27, 2024

Looking at the code I believe an additional filter here is required

filter(GUIDELINES %like% "^(CLSI|EUCST)") %>%

filter(HOST=='HUMAN') %>%

from amr.

msberends avatar msberends commented on August 27, 2024

Nice catch! I removed all animal records from the file, and now:

data.frame(mo = "E. coli",
           AMC = 4) %>%
  as.rsi(guideline = "CLSI 2019")
#> NOTE: Using column `mo` as input for `col_mo`.
#> NOTE: Assuming column `AMC` (amoxicillin/clavulanic acid) contains MIC values.
#> => Interpreting MIC values of `AMC` (amoxicillin/clavulanic acid) using guideline CLSI 2019 ... OK.
#>        mo AMC
#> 1 E. coli   S

I'm running checks now and will then upload it to the master branch. I'll let you know when it's done!

You're just in time, I was about to release a new version to CRAN! So if you can confirm this is fixed, I will 😉

from amr.

antunderwood avatar antunderwood commented on August 27, 2024

Great - thank you.
How do I install locally. Check out code and devtools build?

from amr.

msberends avatar msberends commented on August 27, 2024

📋 Please take part in our survey!

Now you're at it, please fill in our short questionnaire! You can fill it in completely anonymously. If you know others using this AMR package, please ask them to fill it in too.

Your valuable input will help to improve the package and its functionalities 🙂

from amr.

antunderwood avatar antunderwood commented on August 27, 2024

Survey completed

from amr.

antunderwood avatar antunderwood commented on August 27, 2024

No, just do:

remotes::install_github("msberends/AMR")

It will install the latest beta version to your computer and then you can just run your code again (you might need to refresh your R session). But this issue is not yet fixed, I'm now also fixing your other issue in one go 🙂

Let me know when it's ready for testing

from amr.

msberends avatar msberends commented on August 27, 2024

Ready! You can test the 'new' as.rsi() 😄

Thanks for filling in the survey!

from amr.

antunderwood avatar antunderwood commented on August 27, 2024

Sorry for the late reply. Was checking out my comparison and it's much improved. The fixes for human only and the conserve_capped_values work a treat.

I was running into some more discrepancies.

It turns out that exports from Vitek have values such as <=.25 (i.e with no leading 0). as.mic can't interpret this and converts the value to NA

I can solve this by transforming my dataframe as follows

 dplyr::mutate(across(-c(id,Species), str_replace, "([<>]=*)\\.", "\\10.")) 

would you consider making a modification to the as.mic function to accommodate this? Should I raise a new issue?

from amr.

msberends avatar msberends commented on August 27, 2024

No problem about the late reply, wasn’t that late!

Using across() already, nice 😜

Sure thing, I’ll fix it in the morning. New issue would be best, I’ll handle it. Many thanks again!

from amr.

msberends avatar msberends commented on August 27, 2024

Fix released to official R repository

Just a small notice: we released a new software version, containing the fix to this issue. Please update your version using either the user interface of your software, or by running:

install.packages("AMR")

from amr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.