Comments (5)
mridgway
commented on June 16, 2024
I can see that while it may be clear what it's doing, it may be unclear why this is needed. It's probably a good idea to add a "why" section to the readme with an example higher order component that illustrates the issue.
from hoist-non-react-statics.
nwshane
commented on June 16, 2024
Okay. I'll write a Why section up later and you can give me feedback on whether it's helpful or not.
from hoist-non-react-statics.
menelike
commented on June 16, 2024
One could also link to https://facebook.github.io/react/docs/higher-order-components.html#static-methods-must-be-copied-over
from hoist-non-react-statics.
nwshane
commented on June 16, 2024
@menelike Ah, yeah that do the trick. Thanks for the link!
from hoist-non-react-statics.
mridgway
commented on June 16, 2024
Fixed in #26. Thanks for mentioning that @menelike.
from hoist-non-react-statics.
Related Issues (20)
- Minified build in npm package makes auditing difficult
- how can I use this package to extract atrributes of dynamic import react component
- Allow react version ^17 HOT 3
- `isMemo` check always returns false for components HOT 2
- Please update description in understendable way
- tsc build declaration error: Subsequent property declarations must have the same type.
- error: Error: While trying to resolve module `hoist-non-react-statics`
- Please release a new version which uses inclusive language
- React.forwardRef results in propTypes etc. being hoisted HOT 8
- Drop React <16.0.0 support? HOT 5
- missing dist/ folder in 3.3.0 release on GitHub HOT 3
- Use the latest react-is feature "isMemo" but without upgrading to the correct version of react-is HOT 11
- Why not supported copy static defaultProps, displayName? HOT 4
- When hoisting: Keep prop value if context value is undefined HOT 7
- Object.getPrototypeOf called on non-object HOT 1
- Reduce bundle size HOT 4
- Incorrect AMD definition HOT 2
- Remove publishConfig block from package.json HOT 3
- Please tell Version for react-redux HOT 1
- Improve typing of third argument HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hoist-non-react-statics.