Use the latest react-is feature "isMemo" but without upgrading to the correct version of react-is about hoist-non-react-statics HOT 11 CLOSED

Use the latest react-is feature "isMemo" but without upgrading to the correct version of react-is

WHY?

We're not:

Do you get the same error as #74?

from hoist-non-react-statics.

Use the latest react-is feature "isMemo" but without upgrading to the correct version of react-is
WHY?

We're not:

hoist-non-react-statics/package.json

Line 27 in 4fbd062

"react-is": "^16.7.0"
Do you get the same error as #74?

Yes, exactly the same error. any solution on this?

from hoist-non-react-statics.

WHY do you use the "higher" feature without upgrading the dependencies, it would caused a lot of error who using this lib.

from hoist-non-react-statics.

WHY do you use the "higher" feature without upgrading the dependencies, it would caused a lot of error who using this lib.

I already told you we upgraded the dependency: https://github.com/mridgway/hoist-non-react-statics/pull/73/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2L27

The package manager you're using seems to create a broken node_modules/ layout. Maybe your build pipeline is responsible for it.

from hoist-non-react-statics.

WHY do you use the "higher" feature without upgrading the dependencies, it would caused a lot of error who using this lib.

I already told you we upgraded the dependency: https://github.com/mridgway/hoist-non-react-statics/pull/73/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2L27

The package manager you're using seems to create a broken node_modules/ layout. Maybe your build pipeline is responsible for it.

No~~ 16.7.0 does not have the isMemo function either, it's on 16.8.1

see here: codesandbox/codesandbox-client#1521 (comment)

from hoist-non-react-statics.

quote here:

So this means that the requested version by hoist-non-react-statics is ^16.6.3, and the resolved version is 16.7.0, which is correct. isMemo got added in 16.8.1.

from hoist-non-react-statics.

Sorry, my bad, my misunderstanding.

from hoist-non-react-statics.

Using hoist-non-react-statics with NextJS is also causing this problem for me

TypeError: ReactIs.isMemo is not a function

Which is the fix? If isMemo is added in 16.7.0 shouldn't it be working?

Thanks for your time in advance.

from hoist-non-react-statics.

This is likely an issue with the build setup from NextJS. next requires [email protected] which does not include isMemo. It would be solved automatically if next wouldn't pint their dependencies to PATCH but rather MAJOR but they insist on it.

from hoist-non-react-statics.

I'm also getting this error from react-redux connect() method after installing on new machine, right now I'm just checking if

If (isMemo && If isMemo(component))

in the .cjs file locally to get around it for now... any reason not to put the "react-is" dep to "16.8.1"?

from hoist-non-react-statics.

@DBeardionaire your build setup is probably broken. Try resolutions field in your package.json to force a single version.

Why we dont bump the version? We dont need to as is shown in the conversation here.

from hoist-non-react-statics.