mradziwo / msgpack_labview Goto Github PK

You have wired mistakenly the wrong type representation at map 16 decodeing. U32->U16

the plus 2 is wrong. The number of bytes followed by bin8 byte is the number of len without +2

Hi mradziwo,

I just found the time to push some changes to my repo that I made last year. They are not good enough to open a pull request but there may be some points you might want to have an eye on it. PronovaPaul recently pushed some really nice changes (features, no openG-dependency). Among other things he worked on the same problem like me:

1. array encoding:
   We both use the static type information and for fixed-size types the encoded data can be build by interleaving header and data. And at this point our solutions differ. Here I cast the array to a byte-array, reshape it according the elements size, add a header column and reshape it again (see enc_a_*.vi). In my short test this is about six times faster than Pauls solution with element-wise encoding, so it might be an interesting version to consider. But I'm not sure about all implications, esp. for multidimensional arrays. In this case additional array headers have to be added... But generally, array reshaping should be a quite fast operation because the the array's content is not accessed.

2. enum-encoding:
   I added an option to to switch between encoding as integer or the enum string. This sometimes can be helpful.

And because of the increasing number of options it might be a good time to change to a single config cluster input instead of lots of boolean/enum inputs.

Well, just some thoughts....

regards,
Zoyo

You forgot in some cases to wire the delete array index input. Per default this delets the last n elements! But you need to delete beginning at index 0.

Hi,
I just see that decodeObject.vi calls for values of 0..127 decodeInt.vi. This has a case for these values, which are positive fixint, but convert it to i8. I would expect that decodeObject.vi should call decodeUInt.vi which implements this case and converts it to the correct u8. Maybe I missed something but this looks odd.

kind regards,
Christian

Hi,
arrays are encoded wrong. Only the first element of the input-array gets encoded to msgpack and repeated for all elements in the output-array. In the first loop of encodeArray.vi the Index(1D)-input should eventually be connected to the i-terminal of the loop.

regards,
Zoyo

I was able to modify your decodeMap VI to restore dictionarys correctly.

Maybe you will update this to your code. With the JSONtext.lvlib:To JSON Text.vim (from VI package manager) this will result in a correct json syntax for dict dict :-)

y

Hey Mike,

Is there a way that you could save this project as a Labview 2015 VIs? I can't currently open any of the items.

Thanks,
-Paul