mprymek / bertgate Goto Github PK

Hello,

Thank you for your efforts in writing this library, would it be possible for you to tag your releases?

Your most recent jump to elixir 1.6 introduced a breaking change to a production app. Although we are now using a commit sha I believe breaking changes are more easily communicated via semantic versioning.

Just a suggestion, thanks again 👍

Hello.
I looked at your project which is really good .
I used for now to benchmark different solutions for a RPC solution using Elixir using TCP and it looks like promising (similar to Thrift) and faster my own RPC solution.
Just I'm wonder why do you use blocking (synchronous) request handling ?

lib/server.ex:140

defp receive_packet(transport,socket) do
      # this is a blocking entrypoint -> we will use infinity here
      <<payload_size::size(32)>> = recv(transport,socket,4,:infinity)
      data = recv(transport,socket,payload_size,5000)
      Bert.decode(data)
end

Why you don't use non-blocking (asynchronous) model which will lead to catch more requests and use data streaming to reunite the TCP packets ?

Regards

Hello.

In your README you mention: it isn't secure: you can still be DDOSed by excessive atom creation.

Do you have any idea to make more secure to avoid DDOS and crash the VM ?

What do you think about the use of the [:safe] option in the :erlang.term_to_binary/2 and :erlang.binary_to_term/2 - which will allow to safely decode without creating new atoms ?

Regards

Is it possible as below?

$ mix sever --port=9000 --public_module=Bert,CalcPublic

Or, initial option code in mix.exs?

In the README:

for the mix.exs dep include, it should be:
:bert_gate instead of :bertgate
Took me awhile to figure that out. (still learning Elixir)

Also, if you add a @moduledoc for your mix tasks, they would show up when you run mix help

Cool project by the way, first time I've used BERT-RPC.