mpp-lsm / mpp Goto Github PK

• Remove MPPGovEqnSetInternalCouplingVars() and MPPGovEqnSetCouplingVars() as procedures

• Rename MPPGovEqnAddCouplingCondition() to MPPGovEqnAddBoundaryCouplingCondition

• Rename MPPGovEqnSetCouplingVars() to MPPGovEqnSetBoundaryCouplingVars

• Rename MPPGovEqnSetBothCouplingVars() to MPPGovEqnSetCouplingVars()

Add following command line options:

• Ability to prescribe ET, soil BC, and output filename
• Ability to simulate following mesh configurations:
  • Mesh for an oak tree with top-soil soil layer as BC,
  • Mesh for a pine tree with top-soil soil layer as BC,
  • Mesh for an oak and pine tree with top-soil soil layer as BC,

Encountered following error when testing on Ubuntu:

• Compiler error during installation. MPI library was installed via PETSc.
• Segmentation fault in thermal_mms test due to uninitialized variable.

Add subroutine to set up a mesh for few default configurations so as to avoid code repetition
(e.g. vsfm_sy1991_problem.F90#L267, vsfm_celia1990_problem.F90#L171)

• Mesh configuration 1:
  • domain extent in x, y, and z direction
  • nx, ny, nz
  • internal connection type: x-only, y-only, z-only, or in all three directions.
• Mesh configuration 2:
  • min and max in x, y, and z
  • nx, ny, nz
  • internal connection type: x-only, y-only, z-only, or in all three directions.

Derivative of thermal conductivity at the interface w.r.t. to up/down pressure needs
to be accounted for in the jacobian computation

dtherm_dP_up   = (dist_up*therm_cond_dn/therm_cond_up) * therm_cond_ave_over_dist/(dist_up*therm_cond_dn + dist_dn*therm_cond_up) * dsat_dP_up
dtherm_dP_dn   = (dist_up*therm_cond_up/therm_cond_dn) * therm_cond_ave_over_dist/(dist_up*therm_cond_dn + dist_dn*therm_cond_up) * dsat_dP_dn

Presently MPPThermalSetSoils() does not set soil properties for boundary conditions.

Presently MPPThermalSetSoils() is defined as:

  subroutine MPPThermalSetSoils(thermal_mpp, begc, &
                           endc,               &
                           thermal_filter,                 &
                           thermal_lun_type,               &
                           thermal_watsat,                 &
                           thermal_csol,                   &
                           thermal_tkmg,                   &
                           thermal_tkdry                   &
                           )

sets all properties of soils is set at once.

Add new subroutine(s) that:

• Set properties one at a time.
• Set properties for internal, boundary, and source-sink auxiliary variables.

The following subroutines should be consolidated:

ThermalEnthalpySoilAuxSetHeatCap
ThermalEnthalpySoilAuxSetThermalCondWet
ThermalEnthalpySoilAuxSetThermalCondDry
ThermalEnthalpySoilAuxSetThermalAlpha
ThermalEnthalpySoilAuxSetSoilDensity

The duplicate code in MultiPhysicsProbVSFM.F90#L1916 and MultiPhysicsProbVSFM.F90#L1999
should be replaced.

Presently, the restart is hardcoded to only support 1 GE (see MultiPhysicsProbVSFM.F90#L674)