mpezzi / bootstrap Goto Github PK

Date fields with jQueryUI calendar popups are just hidden. No way to edit them.
Works with Garland, though.

Actually, mostly PHP Notices.

When the PHP error level is set to Notice, you can see that especially the form functions produce drupal messages in many places (from what I've seen, the functions try to access non-existent indices in arrays and such). This essentially leads to unusability as admin theme.

I'll roll up a patch as soon as possible for review

First, let me say thanks for the great work.

I followed the instructions and installed the base theme, then created a new custom sub theme based on the starterkit. But I can't get the WYSIWYG module to load CKEditor.

I get the following error:

wysiwyg.js:237ReferenceError: Can't find variable: jQuery

... it does work if I move all the scripts in html.tpl.php to the head.

What do you think about using the jquery_update module to use jQuery 1.7? Evidently 7.x-2.x-dev branch is now on jQuery 1.7 (It provides a selection box for choosing 1.5 or 1.7 in the performance menu, i.e., same menu as clear cache button and cache / aggregation settings.)

As it is right now, the bootstrap_pager() function breaks the AJAX functionality of Views.

This is due to two things:

1. the "pager" class is removed from the list. I see that you did it to avoid the default Drupal theming and to distinguish Bootstrap pagination from Bootstrap pager. However, Views won't attach to the links if this class isn't present. Another solution for removing the Drupal theming might be to introduce a Drupal-reset CSS file that clears the styles before adding the Bootstrap CSS. I tested it and the functionality comes back but now there is still the problem of having a mixed Bootstrap representation of pager and pagination. Although resulting in a rather hacky CSS, one might declare CSS rules that will clear the pager-styles when inside a pagination wrapper... maybe you have a better idea?
2. For the active pager, you added an <a> tag around the number which is interpreted by Views as an actual pager-link. According to the Bootstrap docs, you can also use a <span> to retain the theming.

Hi,

I like your work. I think it will make sens to merge with http://drupal.org/project/twitter_bootstrap to avoid duplication of effort. The owners of the repository will certainly give you an write access if you ask.

Their is a lot of ugly things in http://drupal.org/project/twitter_bootstrap but it should not take long to merge both project.

In includes/table.inc: bootstrap_table assumes $variables['attributes']['class'] to be an array which is not always true. It is also possible that it is just a string (drupal_attributes() allows both).

In case of the Panels overview page, I get a PHP error following a WSOD.

Hey,

first I wanted to thank you for this great Bootstrap Drupal wrapper! Nice work :)

I wonder though why you implemented those nav-switches in the theme settings. I mean, it is nice to see the different bootstrap elements in action but their behaviour is rather confusing. It seems to me that bootstrap_nav as well as bootstrap_nav_sub should not be used at the same time since both of them contain the same information. This could be changed in a subtheme of course, but it why do it in the first place? Additionally, the output of bootstrap_nav_user setting seems to be different when bootstrap_nav is activated.

Generally speaking, having a few settings available is a good thing, I believe. However, the Nav-settings are kinda useless at this point. I suggest to provide a subtheme that uses the sub-nav instead of the top-nav and remove both the switches (nav and nav_sub). That way the base theme becomes a bit simpler and developers can still see how the subnav markup looks like. I'd even go a bit further and make the basetheme exactly like the bootstrap docs example, i.e. top nav bar, jumbotron page-titles (instead of jumbotron site-name), subnav for the primary-tasks, tabs for the secondary, and so on ..

What do you think?

the drop-down menus dont work, i have updated jquery and all that.