Describe the bug

when the request body is encoded using (url.Values{}).Encode() , the -d flag should not be used. Instead, the encoded string should be appended directly to the URL

To Reproduce
Steps to reproduce the behavior:

req, _ := http.NewRequest("PUT", "http://www.example.com/abc/def.ghi?jlk=mno&pqr=stu", bytes.NewBufferString((url.Values{"test": []string{"1", "2"}}).Encode()))
command, _ := http2curl.GetCurlCommand(req)
fmt.Println(command)

// output: curl -X 'PUT' -d 'test=1&test=2' 'http://www.example.com'  

Expected behavior
the output should be curl -X 'PUT' 'http://www.example.comtest=1&test=2'

Versions (please complete the following information, if relevant):

• Software version: v1.0.0
• OS: Mac
• Golang version: 1.21.4

http://semver.org/
https://dave.cheney.net/2016/06/24/gophers-please-tag-your-releases

Here's a failing test

func TestItQuotesFormData(t *testing.T){
    form := url.Values{}
    form.Add("age", "10")
    form.Add("name", "Hudson")
    body := form.Encode()

    req, _ := http.NewRequest(http.MethodPost, "http://foo.com/cats", ioutil.NopCloser(bytes.NewBufferString(body)))
    req.Header.Set("API_KEY", "123")

    command, _ := GetCurlCommand(req)

    expected := `curl -X POST -d "age=10&name=Hudson" -H "API_KEY: 123" 'http://foo.com/cats'`

    if command.String() != expected{
        t.Error("Didnt work, got")
        t.Log(command.String())
        t.Log("expected")
        t.Log(expected)
    }

}

Gets

    http2curl_test.go:56: Didnt work, got
    http2curl_test.go:57: curl -X POST -d age=10&name=Hudson -H "API_KEY: 123" 'http://foo.com/cats'
    http2curl_test.go:58: expected
    http2curl_test.go:59: curl -X POST -d "age=10&name=Hudson" -H "API_KEY: 123" 'http://foo.com/cats'

The resulting curl is not valid because the form data needs to be quoted. I tried playing with your algorithm for quoting but ended up breaking lots of stuff. Will give it a go later unless you can see an easy fix?

Since today, I'm facing the below issue with the package "gorequest" about this package.

Did something change? Can I do something in my app to fix it?

../github.com/parnurzeal/gorequest/gorequest.go:31:2: cannot find package "github.com/moul/http2curl" in any of:
	/usr/local/go/src/github.com/moul/http2curl (from $GOROOT)
	/go/src/github.com/moul/http2curl (from $GOPATH)

Thanks in advance,

Describe the bug
A clear and concise description of what the bug is.

after #31 merged

client.Do(req) https request will return http: ContentLength=xx with Body length 0 error after http2curl.GetCurlCommand(req) called

To Reproduce

str := `{"hello":"world"}`
req, _ := http.NewRequest("POST", `https://www.baidu.com`, strings.NewReader(str))
req.Header.Set("Content-Length", strconv.FormatInt(int64(len(str)), 10))
client := &http.Client{
    Transport: &http.Transport{
        TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
    },
}
http2curl.GetCurlCommand(req)
_, err := client.Do(req)
if err != nil {
    fmt.Println("err: ", err)
}

/cc @Dzalevski

Hi. I'd like to know what is the differences between use the curl command to use the native net/http package to perform http requests. I mean, there's differences in DNS resolution, timeouts, or any configuration that could work different to the same request?

I'm asking this because before I was using a 3rd party package that use this http2curl package to perform the requests, and now, I'm using another one that uses the net/http package.
Unfortunately, for the same request, I'm seeing o lot of timeouts which dit not happen before.

Thanks in advance.

Describe the bug

GetCurlCommand() can not get the request host.

To Reproduce

package main

import (
	"fmt"
	"net/http"

	"moul.io/http2curl"
)

func greet(w http.ResponseWriter, r *http.Request) {
	command, _ := http2curl.GetCurlCommand(r)
	fmt.Fprintf(w, command.String())
}

func main() {
	http.HandleFunc("/", greet)
	http.ListenAndServe(":8080", nil)
}

$ curl --location --request GET 'http://127.0.0.1:8080/'

Output: curl -X 'GET' -d '' -H 'Accept: */*' -H 'User-Agent: curl/7.77.0' '/'

Expect output: curl -X 'GET' -d '' -H 'Accept: */*' -H 'User-Agent: curl/7.77.0' 'http://127.0.0.1:8080/'

There seems to only be one test using it and these can just be written as plain Go tests, or use the more common testify.

It would be nicer to use:

type CurlCommand []string

So that I can print it as a multiline:

fmt.Println(strings.Join(command, " \\\n"))

Describe the bug
Not possible to "install/get" module

To Reproduce
Steps to reproduce the behavior:

1. 'go get moul.io/http2curl'
2. See error:
   'go: moul.io/http2curl upgrade => v2.0.0+incompatible
   go get: moul.io/[email protected]+incompatible/go.mod: verifying module: moul.io/[email protected]+incompatible/go.mod: reading https://gocenter.io/sumdb/sum.golang.org/lookup/moul.io/[email protected]+incompatible: 404 Not Found'

Expected behavior
being able to install module and use it in go

Screenshots / Logs
'go: moul.io/http2curl upgrade => v2.0.0+incompatible
go get: moul.io/[email protected]+incompatible/go.mod: verifying module: moul.io/[email protected]+incompatible/go.mod: reading https://gocenter.io/sumdb/sum.golang.org/lookup/moul.io/[email protected]+incompatible: 404 Not Found'

Versions (please complete the following information, if relevant):

• Software version: 'v2.0.0+incompatible'
• OS: OSX:10:15:6
• Golang version: go version go1.14.5 darwin/amd64
• GOPROXY=https://gocenter.io (but same error as well witout proxy)

Additional context
Add any other context about the problem here.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• fix(deps): update dependency remark-lint to v9.1.2
• chore(deps): update all (actions/cache, codecov/codecov-action, golangci/golangci-lint-action, markdownlint-cli)
• chore(deps): update all (major) (actions/cache, actions/checkout, actions/setup-go, alex, codecov/codecov-action, ghcr.io/codfish/semantic-release-action, golangci/golangci-lint-action)
• fix(deps): update remark (major) (remark-cli, remark-lint)
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Describe the "bug"
It's a little replacement that could solve an issue into doc.go file, if you don't mind take a look into it to be noticed that you should remove "// import "moul.io/http2curl/v2" from github.com/moul/http2curl/doc.go 'cause it's reproducing the error below

../../gopkg.in/ns3777k/go-shodan.v3/shodan/shodan.go:7:2: code in directory /Users/richardsonlima/go-workspace/src/github.com/moul/http2curl expects import "moul.io/http2curl"

Versions:

• OS: [Mac 11.0.1 (20B29)]
• Golang version [go1.15.4 darwin/amd64]