mosemister / ships-2ndgen Goto Github PK

Specifically, I get craters in the ocean surface when my airship takes off from being partially below water level. I know this is Minecraft water mechanics trying to cope with structure movement but is there a way to stop these from happening?

The issue here is likely down to water source block creation because of two waterlogged blocks adjacent to the same block.
Suggested resolution: unwaterlog all blocks on move/altitude change

Hi

What do you think about using maven?

This is the github for Ships 5. As everything was started from the ground up for Ships 6 due to a number of reasons, it has its own Github page. Please use it.

https://github.com/Minecraft-Ships/ShipsForCore/issues

I have had a neat idea for making this plugin truly stand apart from Movecraft. How about if you board a ship your item hotbar will be replaced by plugin items. (Configurable in the plugin config in case somoene wants the old experience) Those items can be used to control your ship instead of having to use signs. I think this would make it not only easier but more fun for players to use.

I am using the prealpha-2 build (I assumed this was the most recent one). When I create a ship and rotate it using the wheel, the wheel sign does not turn correctly and the ship stops working. Specifically, it says that I need more wool blocks, even though before rotating it was fine.

Sorry if you are aware of this issue and this is an old version, I assumed since it was downloadable that it was available to report bugs on.

Using the latest build of ships [6.0.0.0 Alpha 3.0), I can create all types of vessel. However, when I attempt to move them, it won't do anything. If I click the signs again, it says "Your vessel is already moving. Please wait for it to finish". When I click the license sign, it provides me with infos on the ship and about special blocks, the wool blocks.

After that, I tried to use Ships 5.0.1.14, but then I had another issue. Ships won't let me create a license sign at all. Following the instructions on your bukkit page, I placed the sign just to get nothing. The sign does not change. When I only write on the first line, the plugin wants me to enter a name on line 3. If I do so, I get the following message: "[Ships] is not installed on the server", although I know I installed ships and the commands are working.

Hi,

I have a error with your plugin :
The plugin was in v6.0.0.0
The spigot server: git-Spigot-1a3504a-84f3da3 (MC: 1.13.2) (Implementing API version 1.13.2-R0.1-SNAPSHOT)

[12:29:48] [Server thread/INFO]: normanfeltz issued server command: /ships shiptype [12:29:48] [Server thread/ERROR]: null org.bukkit.command.CommandException: Unhandled exception executing command 'ships' in plugin Ships v6.0.0.0 at org.bukkit.command.PluginCommand.execute(PluginCommand.java:48) ~[Spigot-1.13.jar:git-Spigot-1a3504a-84f3da3] at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:141) ~[Spigot-1.13.jar:git-Spigot-1a3504a-84f3da3] at org.bukkit.craftbukkit.v1_13_R2.CraftServer.dispatchCommand(CraftServer.java:704) ~[Spigot-1.13.jar:git-Spigot-1a3504a-84f3da3] at net.minecraft.server.v1_13_R2.PlayerConnection.handleCommand(PlayerConnection.java:1621) ~[Spigot-1.13.jar:git-Spigot-1a3504a-84f3da3] at net.minecraft.server.v1_13_R2.PlayerConnection.a(PlayerConnection.java:1461) ~[Spigot-1.13.jar:git-Spigot-1a3504a-84f3da3] at net.minecraft.server.v1_13_R2.PacketPlayInChat.a(PacketPlayInChat.java:45) ~[Spigot-1.13.jar:git-Spigot-1a3504a-84f3da3] at net.minecraft.server.v1_13_R2.PacketPlayInChat.a(PacketPlayInChat.java:1) ~[Spigot-1.13.jar:git-Spigot-1a3504a-84f3da3] at net.minecraft.server.v1_13_R2.PlayerConnectionUtils.lambda$0(PlayerConnectionUtils.java:9) ~[Spigot-1.13.jar:git-Spigot-1a3504a-84f3da3] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_212] at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_212] at net.minecraft.server.v1_13_R2.SystemUtils.a(SourceFile:199) [Spigot-1.13.jar:git-Spigot-1a3504a-84f3da3] at net.minecraft.server.v1_13_R2.MinecraftServer.b(MinecraftServer.java:896) [Spigot-1.13.jar:git-Spigot-1a3504a-84f3da3] at net.minecraft.server.v1_13_R2.DedicatedServer.b(DedicatedServer.java:417) [Spigot-1.13.jar:git-Spigot-1a3504a-84f3da3] at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:831) [Spigot-1.13.jar:git-Spigot-1a3504a-84f3da3] at net.minecraft.server.v1_13_R2.MinecraftServer.run(MinecraftServer.java:729) [Spigot-1.13.jar:git-Spigot-1a3504a-84f3da3] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_212] Caused by: java.lang.ArrayIndexOutOfBoundsException: 1 at org.ships.commands.legacy.shiptype.LegacyShipTypeCommand.run(LegacyShipTypeCommand.java:28) ~[?:?] at org.ships.commands.legacy.LegacyShipsCommand.run(LegacyShipsCommand.java:62) ~[?:?] at org.ships.implementation.bukkit.command.BCommand.onCommand(BCommand.java:24) ~[?:?] at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46) ~[Spigot-1.13.jar:git-Spigot-1a3504a-84f3da3] ... 15 more

Cordialy

Norman F.

I’ve lost several ships due to falling off the back while EOT was enabled. Can you please add a setting so that EOT is shut off when the captain leaves the ship or logs off? Alternatively provide a way for a captain to recover their ship after it has moved on its own from where they left it?

In the latest versions of ships entities are not teleported with the ships. Is this intentional or is entity passengers a planned feature? It would seem easy to implement just by extending the logic that detects other players on the ship to all or a configured subset of entities.

I can't disable burner in the config for airships. I've tried and it says disabled in the config, but in the [ships] information area, there's still 'Requires Burner: True"
airship
name

How can I fix this?

I don't know if you have caught this bug yet but here it is. If you hover above a move sign on a watership, it will go down in to the water, and if you click from the bottom of the move sign it will go up in the air and hover one block in the water, and you can't make it go down unless there's water under it.

Pretty self explanatory. When traveling in a boat, 1.14.4, any Kelp thats in the way of the boat will stop it from being able to move on. I've tried making kelp a material in the config to try and make it apart of the boat every time I run into on the ocean, but it's tedious. I feel the ship should be able to just run through plants like that.

I have an issue. Actually it's several issues that appear to stem from the same bug.
The first is this:
[17:44:37 ERROR]: Exception when Amicus1 attempted to tab complete ships ship
org.bukkit.command.CommandException: Unhandled exception during tab completion for command '/ships ship ' in plugin Ships v6.0.0.0
at org.bukkit.command.PluginCommand.tabComplete(PluginCommand.java:150) ~[patched_1.14.4.jar:git-Paper-167]
at org.bukkit.command.Command.tabComplete(Command.java:93) ~[patched_1.14.4.jar:git-Paper-167]
at org.bukkit.command.SimpleCommandMap.tabComplete(SimpleCommandMap.java:244) ~[patched_1.14.4.jar:git-Paper-167]
at org.bukkit.craftbukkit.v1_14_R1.CraftServer.tabCompleteCommand(CraftServer.java:1716) ~[patched_1.14.4.jar:git-Paper-167]
at org.bukkit.craftbukkit.v1_14_R1.CraftServer.tabComplete(CraftServer.java:1688) ~[patched_1.14.4.jar:git-Paper-167]
at org.bukkit.craftbukkit.v1_14_R1.command.BukkitCommandWrapper.getSuggestions(BukkitCommandWrapper.java:49) ~[patched_1.14.4.jar:git-Paper-167]
at com.mojang.brigadier.tree.ArgumentCommandNode.listSuggestions(ArgumentCommandNode.java:71) ~[patched_1.14.4.jar:git-Paper-167]
at com.mojang.brigadier.CommandDispatcher.getCompletionSuggestions(CommandDispatcher.java:596) ~[patched_1.14.4.jar:git-Paper-167]
at com.mojang.brigadier.CommandDispatcher.getCompletionSuggestions(CommandDispatcher.java:579) ~[patched_1.14.4.jar:git-Paper-167]
at net.minecraft.server.v1_14_R1.PlayerConnection.lambda$a$3(PlayerConnection.java:563) ~[patched_1.14.4.jar:git-Paper-167]
at net.minecraft.server.v1_14_R1.TickTask.run(SourceFile:18) ~[patched_1.14.4.jar:git-Paper-167]
at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeTask(IAsyncTaskHandler.java:136) ~[patched_1.14.4.jar:git-Paper-167]
at net.minecraft.server.v1_14_R1.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23) ~[patched_1.14.4.jar:git-Paper-167]
at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeNext(IAsyncTaskHandler.java:109) ~[patched_1.14.4.jar:git-Paper-167]
at net.minecraft.server.v1_14_R1.MinecraftServer.aX(MinecraftServer.java:1012) ~[patched_1.14.4.jar:git-Paper-167]
at net.minecraft.server.v1_14_R1.MinecraftServer.executeNext(MinecraftServer.java:1005) ~[patched_1.14.4.jar:git-Paper-167]
at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.awaitTasks(IAsyncTaskHandler.java:119) ~[patched_1.14.4.jar:git-Paper-167]
at net.minecraft.server.v1_14_R1.MinecraftServer.sleepForTick(MinecraftServer.java:989) ~[patched_1.14.4.jar:git-Paper-167]
at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:922) ~[patched_1.14.4.jar:git-Paper-167]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_201]
Caused by: java.lang.NullPointerException

Obviously this one happens when i try to use /ships ship. Even though right clicking the licence sign gives info, it can't find any of my three ships. It gives "An internal error occured while trying to complete this command.

Secondly, when i try to move my ship, even though it has previously worked, it turns the whole thing to bedrock and says "Failed to find Licence sign". I have broken the licence sign, deleted the ship's yml file, replace the sign, to no avail. Please help.

Using MC 1.9 and latest spigot, with the 1.9 version of ships:
https://www.spigotmc.org/resources/ships-mc-1-8-1-9.2072/update?update=74732

[12:37:46] [Server thread/ERROR]: Error occurred while enabling Ships v5.0.1.7 (Is it up to date?)
java.lang.IllegalArgumentException: Cannot set to an empty path
    at org.apache.commons.lang.Validate.notEmpty(Validate.java:321) ~[minecraft_server.jar:git-Spigot-f04e043-52c7fc0]
    at org.bukkit.configuration.MemorySection.set(MemorySection.java:163) ~[minecraft_server.jar:git-Spigot-f04e043-52c7fc0]
    at org.bukkit.configuration.MemorySection.set(MemorySection.java:193) ~[minecraft_server.jar:git-Spigot-f04e043-52c7fc0]
    at MoseShipsBukkit.Utils.ConfigLinks.MaterialsList.save(MaterialsList.java:240) ~[?:?]
    at MoseShipsBukkit.Ships.onEnable(Ships.java:57) ~[?:?]
    at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:292) ~[minecraft_server.jar:git-Spigot-f04e043-52c7fc0]
    at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:340) [minecraft_server.jar:git-Spigot-f04e043-52c7fc0]
    at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:405) [minecraft_server.jar:git-Spigot-f04e043-52c7fc0]
    at org.bukkit.craftbukkit.v1_9_R1.CraftServer.loadPlugin(CraftServer.java:361) [minecraft_server.jar:git-Spigot-f04e043-52c7fc0]
    at org.bukkit.craftbukkit.v1_9_R1.CraftServer.enablePlugins(CraftServer.java:321) [minecraft_server.jar:git-Spigot-f04e043-52c7fc0]
    at net.minecraft.server.v1_9_R1.MinecraftServer.t(MinecraftServer.java:411) [minecraft_server.jar:git-Spigot-f04e043-52c7fc0]
    at net.minecraft.server.v1_9_R1.MinecraftServer.l(MinecraftServer.java:376) [minecraft_server.jar:git-Spigot-f04e043-52c7fc0]
    at net.minecraft.server.v1_9_R1.MinecraftServer.a(MinecraftServer.java:331) [minecraft_server.jar:git-Spigot-f04e043-52c7fc0]
    at net.minecraft.server.v1_9_R1.DedicatedServer.init(DedicatedServer.java:269) [minecraft_server.jar:git-Spigot-f04e043-52c7fc0]
    at net.minecraft.server.v1_9_R1.MinecraftServer.run(MinecraftServer.java:527) [minecraft_server.jar:git-Spigot-f04e043-52c7fc0]
    at java.lang.Thread.run(Unknown Source) [?:1.8.0_66]

Players are left behind airships when they are going at speeds higher than the length of the boat

Commands:

• [x] Ships info
• [ ] Ships info Ship type
• [ ] Ships info Ship name
• [ ] Ships teleport Ship name
• [ ] Ships teleport Ship name players...

Algorithms:

• [ ] Ships 6 movement
• [x] Ships 5 movement
• [ ] Ships 6 autopilot path finder
• [x] Ships 6 block finder

Features:

• [x] Remove ship on licence break
• [ ] Logout overboard bug fix
• [ ] Force name on licence sign config option
• [ ] Structure destroy on unlicence config option
• [ ] Protected Ships option
• [ ] Subpilots
• [ ] ShipsLock
• [x] Ships get stored into temp storage
• [x] Ships are automatic removed from temp storage when not used
• [ ] Command tab completion for all default ships commands

Ship types:

• [x] Airship
• [ ] Marsship
• [x] Watership
• [ ] Submarine
• [ ] Plane
• [ ] Solarship
• [ ] UnnamedShip (the old hybridship)
• [ ] Hybridship (revisited)

Other plugins:

• [ ] GriefProtectionHook
• [ ] WorldGuardHook

Events:

• [x] ShipAboutToMoveEvent
• [x] ShipTransformEvent
• [ ] ShipTeleportEvent
• [ ] ShipTransformSectionEvent
• [ ] ShipTeleportSectionEvent
• [ ] ShipFallingEvent
• [ ] AutopilotAttemptMoveEvent
• [ ] ShipTrackedEvent
• [x] ShipCreatedEvent
• [x] ShipLoadEvent
• [x] ShipUnloadEvent

API:

• [ ] CustomInventoryAPI

Is it possible to make the ships not automatically consider any adjacent material blocks part of the ship, but only update the structure when the player wants it to (sign click)?

Hi,
I like your plugin, and i want to use AutoPilot, can you upload ships version 6 for test ?
Thanks, sorry for my language.

I'm unsure if this plugin currently has any land-vehicle capabilities as I haven't had the chance to look super far into it, however according to the plugin description it seems as though you can only create vehicles that travel in/on water and in air. I would like to be able to create ships that I can drive on land with this plugin.

[Sat, 17. Aug 2019 18:54:02 PDT INFO] ships:airship.starmansuper | airship.icanfly4
[Sat, 17. Aug 2019 18:54:02 PDT INFO] ships:airship.jankyship | airship.icanfly4
[Sat, 17. Aug 2019 18:54:02 PDT INFO] ships:airship.galleon | airship.icanfly4
[Sat, 17. Aug 2019 18:54:02 PDT INFO] ships:airship.woomy | airship.icanfly4

This message pops up in my console with various ship ids at the end of the lines. It seems to be caused by a Java for each loop logging each airship Id against the target one. It’s not an error but you might want to check the code that finds a ship based on its id

Update structure. Get facing

Currently I want to use this plugin over Movecraft, since it has active development and actual support. There are only two features that Movecraft has that this plugin does not, this is one of them.

In Movecraft, if you damage a ship until it cannot move any more, it will sink into the ocean. This adds a lot of immersion and I think it would be relatively easy to implement, but I'm not sure, which is why I am asking.

How possible is this to implement? Would you consider adding this feature?

‘Nuff said. In the unlikely event that you have time, would you consider fleshing out the GitHub wiki?
Sorry for spamming you with issues but I figured I should put them separately.
Some suggestions:
Tutorials for each of the signs and their interactions
Commands page and permissions page
FAQ such as the following:
How to move backward (move sign facing the other way )
How to decrease speed on move sign(still don’t know)

Currently I want to use this plugin over Movecraft, since it has active development and actual support. There are only two features that Movecraft has that this plugin does not, this is one of them.

In Movecraft you can create a sign that "saves" your ship, allowing you to repair it with a sign and a chest that contains the materials needed to repair the ship, as well as a optional cost per block in money (some kind of economy plugin support).

This allows players to create complex ships without worrying that they will be super hard to repair, they only have to provide the supplies and the ship fixes itself.

How possible is this to implement? Would you consider adding this feature?

I continue to get this with when trying to make larger ships! It just doesn't want to allow them to fly! https://pastebin.com/Vz63Y0uP is my set up for airship config where the problem is from.