morpho-labs / safer Goto Github PK

Having this in your .env:

SAFE_NONCE=

changes the signature (weirdly).

https://docs.safe.global/learn/safe-core/safe-core-protocol/signatures

The constant parts need to be sorted so that the recovered signers are sorted ascending (natural order) by address (not checksummed).

• Signatures must be sorted by ascending signers
• Data must be appended at the end as well as the length

my signatures.txt file has the error messages dumped after having denied the signature:

In fact it's not really clear what is the goal of this tool when reading the README

Before calling cast wallet sign here, you can verify if the user has already submitted a signature by running a checking script that is decoding signatures.

Description

parseSignature is logging an error and returning without error data if the signature is malformated.
It can lead to inconsistent signature or invalid processing after

Suggestion

revert the script

if (line.length != 132) {
    revert InvalidSignature();
}

Description

having a 2 step signature can be dangerous and can lead to a wrong message signed, specially if you miss to rerun make hash after payload modifications, you are just resigning the previous hash.

Suggestion

Execute the make hash logic in the make sign:ledger script. I suggest to use a flag option if you want to explicitly use a precomputed hash, even if it is really dangerous to sign a hash without the payload.
I don'k know if its easily feasable. Another solution could be to have another script like make sign:hash

Hello,

I was wondering how I can format this for the make tx to accept my inputs.

Invalid value "[["0x0000000000000000000000000000000000000000",2,[0x00000000,0x00000000]]" for type "tuple(address,uint8,bytes4[])[]"

It can be useful if I want to use the safe backend, in the end

Perhaps users would like to prepare signatures in local but don't push them? Perhaps it would be safer to ignore this folder

Perhaps it's better to set the RPC_URL and use it instead of the foundry.toml configuration because it's likely that someone pushed here credential while if it's in the .env file it's ignored. What do you think?

And we can just check that if the .env variable is empty we fallback to https://eth.llamarpc.com

Useful doc: https://www.notion.so/morpho-labs/Tutorial-How-to-execute-a-tx-as-an-operator-f8e826351683457eaa2a9db379adec31?pvs=1&qid=1%3A7a9132b8-dee4-4230-a841-8877e803cc73%3A5

What we want:

• Be able to create script to generate calldata
• Be able to store already prepared calldata
• Be able to simply sign those calldata (using cast?)
• Be able to collect signatures, concat them and execute the payload on a safe