Adding RX support about react-native-contacts HOT 6 CLOSED

Here we go -> https://github.com/JeanLebrument/react-native-contacts-rx

from react-native-contacts.

Yes, rx is too heavy of a dependency to make it part of the main package. However having a seperate react-native-contacts-rx module would be great.

Let me know if any api changes are needed to make this work. Also after you publish it, we should put a link to it in the readme.

from react-native-contacts.

Good. I will create a separate package then! You don't need to change anything to your API. I will tell when it will be released.

from react-native-contacts.

After few discussions with colleagues, I wonder if creating another package only to add the support of Rx would be overkill. I only extends the contact package by adding rx_ prefixed methods for each method that takes a completionHandler in parameter. (Gist available here: https://gist.github.com/JeanLebrument/304ba2bd8547a6ed4e7f).

My concern is: Is this a good "guideline" to create another package to add the Rx support to an existing package? Or would it be smarter to add an optional support to the main package? (I created an other Gist for the optional support: https://gist.github.com/JeanLebrument/6dc373647b44fb4def7a).

I would like to have your opinion on this question.

from react-native-contacts.

I am all about node style small modules and definitely do not think they are overkill. Along those lines I would love if every package had a [package-name]-rx counterpart, which makes opting in as a consumer dead simple.

Another issue is that not all packaging systems (including I believe the react-native one) respect try/catch since they typically do static analysis to create the bundles.

from react-native-contacts.

Thanks for your feedback, I will do this then.

from react-native-contacts.