Comments (6)
Here we go -> https://github.com/JeanLebrument/react-native-contacts-rx
from react-native-contacts.
Yes, rx is too heavy of a dependency to make it part of the main package. However having a seperate react-native-contacts-rx module would be great.
Let me know if any api changes are needed to make this work. Also after you publish it, we should put a link to it in the readme.
from react-native-contacts.
Good. I will create a separate package then! You don't need to change anything to your API. I will tell when it will be released.
from react-native-contacts.
After few discussions with colleagues, I wonder if creating another package only to add the support of Rx would be overkill. I only extends the contact package by adding rx_
prefixed methods for each method that takes a completionHandler
in parameter. (Gist available here: https://gist.github.com/JeanLebrument/304ba2bd8547a6ed4e7f).
My concern is: Is this a good "guideline" to create another package to add the Rx support to an existing package? Or would it be smarter to add an optional support to the main package? (I created an other Gist for the optional support: https://gist.github.com/JeanLebrument/6dc373647b44fb4def7a).
I would like to have your opinion on this question.
from react-native-contacts.
I am all about node style small modules and definitely do not think they are overkill. Along those lines I would love if every package had a [package-name]-rx
counterpart, which makes opting in as a consumer dead simple.
Another issue is that not all packaging systems (including I believe the react-native one) respect try/catch since they typically do static analysis to create the bundles.
from react-native-contacts.
Thanks for your feedback, I will do this then.
from react-native-contacts.
Related Issues (20)
- Is it possible to get all contacts along with their creation date? HOT 2
- contacts is null on initialize
- How to get or fetch real time contacts in react native HOT 2
- Show Permission Dialog when checking permission. HOT 1
- getContactsByPhoneNumber only returns after match HOT 8
- open platform depended contact list and select a specific contact from there HOT 1
- Interface of phoneNumber contains id property in it but it is not mentioned in the index.d.ts HOT 2
- iOS getById do not return thumbnailPath while getAll does HOT 11
- Contacts Profile changes HOT 2
- [Urgent - Android/Ios] List Contacts get real device show default some phone number HOT 1
- iOS: UIColor created with component values far outside the expected range HOT 3
- isStarred is not working HOT 6
- birthday do not work HOT 2
- getContactsMatchingString search also in addresses HOT 3
- Get Call history HOT 3
- Not able to add image while creating contact HOT 1
- How to Edit or Update contact details like familyName, givenName or number HOT 4
- React Native 0.74 (Bridgeless) Support HOT 4
- Update types for contact fields that may be null HOT 3
- Contact could not be saved when thumbnailPath is invalid on iOS HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-contacts.