Giter Club home page Giter Club logo

Comments (6)

morenoh149 avatar morenoh149 commented on August 27, 2024

looks like the starred option is never unpacked on android

import android.provider.ContactsContract.ContactOptionsColumns

https://developer.android.com/reference/android/provider/ContactsContract.ContactOptionsColumns#STARRED

    @ReactMethod
    public void addContact(ReadableMap contact, Promise promise) {
        if (contact == null) {
            promise.reject("New contact cannot be null.");
            return;
        }
        String givenName = contact.hasKey("givenName") ? contact.getString("givenName") : null;
        String middleName = contact.hasKey("middleName") ? contact.getString("middleName") : null;
        String familyName = contact.hasKey("familyName") ? contact.getString("familyName") : null;
        String prefix = contact.hasKey("prefix") ? contact.getString("prefix") : null;
...

public void addContact(ReadableMap contact, Promise promise) {

from react-native-contacts.

ayelenguini avatar ayelenguini commented on August 27, 2024

Hello! I might have a similar issue to address here. I noticed that the isStarred property though present on the example contact record is not showing on the Contact interface provided by the library:

export interface Contact {
    recordID: string;
    backTitle: string;
    company: string|null;
    emailAddresses: EmailAddress[];
    displayName: string;
    familyName: string;
    givenName: string;
    middleName: string;
    jobTitle: string;
    phoneNumbers: PhoneNumber[];
    hasThumbnail: boolean;
    thumbnailPath: string;
    postalAddresses: PostalAddress[];
    prefix: string;
    suffix: string;
    department: string;
    birthday: Birthday;
    imAddresses: InstantMessageAddress[]
    note: string;
}

Is there a reason for this? Has this property been recently unsupported? Is it because this property is only supposed to be available on Android devices?

Thanks!

from react-native-contacts.

morenoh149 avatar morenoh149 commented on August 27, 2024

@ayelenguini its just an oversight. When we first wrote the example we did not support typescript. Ts annotations were added later by another author. isStarred should be added to the ts definition but we should also check that they are properly set when creating a new contact.

from react-native-contacts.

ayelenguini avatar ayelenguini commented on August 27, 2024

@morenoh149 and what about when requesting the contact list itself? would this property be available on the return object? is it only available on android?

from react-native-contacts.

morenoh149 avatar morenoh149 commented on August 27, 2024

@ayelenguini it's probably missing when requesting the contact list itself as well

from react-native-contacts.

github-actions avatar github-actions commented on August 27, 2024

This issue is stale, please provide more information about the status

from react-native-contacts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.