monomotion / flom Goto Github PK

SSIA

frame_iterator is not a random access iterator, so it can iterate without calling Motion::frame_at in each forwards.

For example:

at frame 0, effector "a" has location of (0,0,0), rotation of None,
at frame 1, effector "a" has location of None, rotation of (0,0,0,0),

(pseudo-motion)

flom can't interpolate frame 0 and frame 1 properly.
So this should be handled as invalid or something.

To conform with Motion::keyframes

SSIA

https://github.com/DeepL2/flom/blob/f1c92580156c2ae80c70c71fb2de067afa6c6531/test/motion_frame.cpp#L64-L69

This issue was generated by todo based on a TODO comment in f1c9258 when #46 was merged. cc @DeepL2.

A sub issue of #23

Result in this:

Motion::get_or_insert_frame can add frame, however there is no way to delete existing frame.

Proposed APIs:

• void Motion::insert_keyframe(long t, Frame const& frame) // by index
• void Motion::insert_keyframe(double t, Frame const& frame) // by time
• Frame Motion::delete_keyframe(long i) // by index
• Frame Motion::delete_keyframe(double t) // by time
• KeyFrameRange Motion::keyframes() // bidirectional iterator (writable)

And delete get_or_insert_frame

This depends on #7
Reference: Arch package guidelines

SSIA, low priority

https://github.com/DeepL2/flom/blob/f1c92580156c2ae80c70c71fb2de067afa6c6531/lib/effector.cpp#L62-L67

This issue was generated by todo based on a TODO comment in f1c9258 when #46 was merged. cc @DeepL2.

https://github.com/DeepL2/flom/blob/8320ff7ad528bda442f427431908e718874e3dca/ci/test-image/package.sh#L18-L23

This issue was generated by todo based on a TODO comment in 8320ff7 when #7 was merged. cc @DeepL2.

SSIA

SSIA

around here:

https://github.com/DeepL2/flom/blob/bcb4c9b68516b46e4bfca1bbf0583e82d867cc95/version.sh#L23

https://github.com/DeepL2/flom/blob/e704b98a48bd196619962c8b511e4ab4aee63fde/lib/motion_io.cpp#L110-L115

This issue was generated by todo based on a TODO comment in e704b98 when #55 was merged. cc @DeepL2.

https://github.com/DeepL2/flom/blob/ac7dd6bd803f43f37c4c7e848b5ddcf450e0df26/lib/motion_io.cpp#L188-L193

This issue was generated by todo based on a TODO comment in ac7dd6b when #31 was merged. cc @DeepL2.

https://cmake.org/cmake/help/v3.13/command/target_link_options.html

https://travis-ci.org/DeepL2/flom/jobs/473237127

[Bintray Upload] Reading descriptor file: bintray.json
[Bintray Upload] Uploading file 'build/dist/flom-0.1+develop-Linux-x86_64.deb' to 0.1+develop/flom-0.1+develop-Linux-x86_64.deb
[Bintray Upload] Bintray response: 409 Conflict. Unable to upload files: An artifact with the path '0.1+develop/flom-0.1+develop-Linux-x86_64.deb' already exists
[Bintray Upload] Uploading file 'build/dist/flom-0.1+develop-Linux-x86_64.pkg.tar.xz' to 0.1+develop/flom-0.1+develop-Linux-x86_64.pkg.tar.xz
[Bintray Upload] Bintray response: 409 Conflict. Unable to upload files: An artifact with the path '0.1+develop/flom-0.1+develop-Linux-x86_64.pkg.tar.xz' already exists
[Bintray Upload] Uploading file 'build/dist/flom-0.1+develop-Linux-x86_64.rpm' to 0.1+develop/flom-0.1+develop-Linux-x86_64.rpm
[Bintray Upload] Bintray response: 409 Conflict. Unable to upload files: An artifact with the path '0.1+develop/flom-0.1+develop-Linux-x86_64.rpm' already exists
[Bintray Upload] Uploading file 'build/dist/flom-0.1+develop-Linux-x86_64.tar.gz' to 0.1+develop/flom-0.1+develop-Linux-x86_64.tar.gz
[Bintray Upload] Bintray response: 409 Conflict. Unable to upload files: An artifact with the path '0.1+develop/flom-0.1+develop-Linux-x86_64.tar.gz' already exists
[Bintray Upload] Uploading file 'build/dist/flom-0.1+develop-Linux-x86_64.zip' to 0.1+develop/flom-0.1+develop-Linux-x86_64.zip
[Bintray Upload] Bintray response: 409 Conflict. Unable to upload files: An artifact with the path '0.1+develop/flom-0.1+develop-Linux-x86_64.zip' already exists
[Bintray Upload] Publishing version '0.1+develop' of package 'latest'...
[Bintray Upload] Bintray response: 200 OK. 

https://github.com/DeepL2/flom/blob/f1c92580156c2ae80c70c71fb2de067afa6c6531/lib/effector.cpp#L41-L46

This issue was generated by todo based on a TODO comment in f1c9258 when #46 was merged. cc @DeepL2.

import_legacy_json and convert_legacy binary are not needed since DeepL2/BlendMotion finished integration to flom

https://github.com/DeepL2/flom/blob/f1c92580156c2ae80c70c71fb2de067afa6c6531/include/flom/effector.hpp#L105-L110

This issue was generated by todo based on a TODO comment in f1c9258 when #46 was merged. cc @DeepL2.

https://github.com/DeepL2/flom/blob/f1c92580156c2ae80c70c71fb2de067afa6c6531/include/flom/frame.hpp#L83-L88

This issue was generated by todo based on a TODO comment in f1c9258 when #46 was merged. cc @DeepL2.

{
  "modelId": "a",
  "loop": "None",
  "effectorTypes": {
    "": {
      "location": "World",
      "rotation": "World"
    }
  },
  "frames": [
    {
      "t": 0,
      "positions": {},
      "effectors": {
        "": {
          "location": {
            "value": {
              "vector": {
                "x": 0,
                "y": 0,
                "z": 0
              },
              "weight": 0
            }
          },
          "rotation": {
            "value": {
              "quaternion": {
                "w": 0.707106949337315,
                "x": -0.0002815439416482546,
                "y": -0.7071065009352508,
                "z": -0.0002815439416482546
              },
              "weight": 0
            }
          }
        }
      }
    }
  ]
}

After load/dump:

{
  "modelId": "a",
  "loop": "None",
  "effectorTypes": {
    "": {
      "location": "World",
      "rotation": "World"
    }
  },
  "frames": [
    {
      "t": 0,
      "positions": {},
      "effectors": {
        "": {}
      }
    }
  ]
}

After some research, only t = 0 frames are not saved during import of motion.

Warning or something like that...

SSIA

This needs to be done to achieve MonoMotion/flom-py#1

https://github.com/DeepL2/flom/blob/74045fa3be6558a95f8ae75d2c869c23afb9c5f6/include/flom/range.hpp#L54-L56

SSIA

Support poac

If possible, do an auto deployment from Travis CI

e.g.
https://github.com/DeepL2/flom/blob/fba1ad3ef3f5068ba13a1b9e66326dbfad5e4f2f/lib/motion.cpp#L76

https://travis-ci.org/DeepL2/flom/builds/474044608

SSIA

At least, main APIs (motion.hpp) should have any documentation.

Generate human-readable docs (doxygen), if possible.

Use gen::nonNegative to generate >=0 double, instead of filtering with RC_PRE

SSIA

This issue was generated by todo based on a TODO comment in 4c8f3aa when #74 was merged. cc @MonoMotion.

https://github.com/DeepL2/flom/blob/dcf611ee70eec3356650f33fa47280e574732adf/test/motion_keyframe.cpp#L115-L120

This issue was generated by todo based on a TODO comment in dcf611e when #57 was merged. cc @DeepL2.

A sub issue of #23

as well as delete_keyframe

Header files in test/ are currently not formatted by clang-format.

https://github.com/DeepL2/flom/blob/f1c92580156c2ae80c70c71fb2de067afa6c6531/lib/effector.cpp#L80-L85

This issue was generated by todo based on a TODO comment in f1c9258 when #46 was merged. cc @DeepL2.

https://github.com/DeepL2/flom/blob/e704b98a48bd196619962c8b511e4ab4aee63fde/lib/effector.cpp#L285-L290

This issue was generated by todo based on a TODO comment in e704b98 when #55 was merged. cc @DeepL2.

SSIA

Will be implemented at DeepL2/flom-py

for convinience

Eigen is better choice than Boost.QVM as a library to treat vectors and quaternions.

Eigen is popular, and pybind11 provides conversion between Eigen and python so that it can help improving performance of flom-py.

https://github.com/DeepL2/flom/blob/f1c92580156c2ae80c70c71fb2de067afa6c6531/include/flom/effector.hpp#L56-L61

This issue was generated by todo based on a TODO comment in f1c9258 when #46 was merged. cc @DeepL2.

Use codecov
Reference: https://github.com/codecov/example-cpp11-cmake

At least g++, use clang++ if possible
(See: https://clang.llvm.org/docs/SourceBasedCodeCoverage.html)

auto const empty = flom::Motion();
empty.is_valid(); // false

¯_(ツ)_/¯

These functions returns .c_str() to temporary std::string object