Giter Club home page Giter Club logo

monarch-disease-ontology-retired's People

Contributors

cmungall avatar gitter-badger avatar kilodalton avatar nicolevasilevsky avatar sbello avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

monarch-disease-ontology-retired's Issues

MDO test case: hyperparathyroidism

From @cmungall on March 9, 2015 1:7

Consider the phenotype parathyroidism and its occurrence in various diseases:
http://www.monarchinitiative.org/phenotype/HP:0000843
(click 'disease' tab)

These are the types of DC:0000201 'hyperparathyroidism'

  • OMIM:145000 ! HYPERPARATHYROIDISM 1
  • OMIM:145001 ! HYPERPARATHYROIDISM 2
  • OMIM:239200 ! Hyperparathyroidism, Neonatal Severe Primary
  • OMIM:600166 ! Hyperparathyroidism, Primary, Caused By Water Clear Cell Hyperplasia
  • OMIM:610071 HYPERPARATHYROIDISM 3

One might think we can use 'hallmark' to cluster diseases. However, the hallmark qualifier is lacking from phenotype association for the phenotype hyperparathyroidism for the above diseases.

For comparison, Orphanet classifications of OMIMs:

To complicate matters, it seems we have no annotations for OMIM:610071 HYPERPARATHYROIDISM 3 (hence it doesn't show up above)

Copied from original issue: monarch-initiative/deprecated-human-disease-ontology#8

Febrile Seizures, Familial

From @cmungall on March 27, 2015 13:27

Compare

[Term]
id: OMIM:604403
name: Generalized Epilepsy With Febrile Seizures Plus, Type 2
is_a: DC:0000159 ! Febrile Seizures, Familial
is_a: DC:0000160 ! Epilepsy, Generalized, with Febrile Seizures Plus

With

[Term]
id: OMIM:604233
name: Generalized Epilepsy With Febrile Seizures Plus, Type 1
is_a: DC:0000160 ! Epilepsy, Generalized, with Febrile Seizures Plus

Is this intentional, or is this just lack of consistency over how restrictive the parent (DC:0000159 ) is?

Copied from original issue: monarch-initiative/deprecated-human-disease-ontology#24

Evaluate disease to phenotype seeming equivalents

From @cmungall on April 7, 2015 2:47

There are many HP and DOIDs with the same label (thankfully HP uses a leading upper case, usually annoying, but this saves us in Protege, where the same label causes massive issues).

I would rather see explicit different labels otherwise this will cause massive confusion.

Also these equivalent labels could be used to generate axioms - not equivalent classes, but something like 'has hallmark phenotype'?

Copied from original issue: monarch-initiative/deprecated-human-disease-ontology#29

OMIM labels

From @mellybelly on March 13, 2015 1:6

OMIM URIs are currently mostly leaf nodes (or merged as equiv classes if name is same as parent and there is only one child). However, there will occasionally be terms in DC or DO with the same label that don't meet requirements for the merge. Since we don't want to make equivalencies for these OMIM terms (or Decipher for that matter), these terms should be appended with (OMIM) in the label to distinguish them from their parents.
For example, you could have:

DOID_1932 Angelman's syndrome
--OMIM_105830 Angelman's syndrome
--Orphanet_98794 Angelman syndrome due to maternal 15q11q13 deletion

Here for example, we might like to have OMIM appended like this:
DOID_1932 Angelman's syndrome
--OMIM_105830 Angelman's syndrome (OMIM)
--Orphanet_98794 Angelman syndrome due to maternal 15q11q13 deletion

Copied from original issue: monarch-initiative/deprecated-human-disease-ontology#9

fix grouping classes

From @nlwashington on March 6, 2015 17:50

i've been looking through our the ontology, i've found some issues.

many of the classes in the merged.obo are missing seemingly pedantic grouping classes.

for example,

id: OMIM:614480
name: Hypertriglyceridemia, Transient Infantile
is_a: DOID:630 ! genetic disease

id: OMIM:145750
name: familial hypertriglyceridemia
def: "A lipid metabolism disorder characterized by elevated triglyceride levels as a result of excess hepatic production of VLDL or heterozygous LPL deficiency." [url:http://en.wikipedia.org/wiki/Familial_hypertriglyceridemia]
comment: OMIM mapping confirmed by DO. [SN].
synonym: "Pure hyperglyceridemia" EXACT []
xref: DOID:0050527
is_a: DOID:3146 ! lipid metabolism disorder
is_a: DOID:630 ! genetic disease

are not related to one another except for both being genetic diseases. why isn't the former also a lipid metabolism disorder? or even better, why aren't they both classified as "hypertriglyceridemia"? that seems like a natural grouping class.

another

id: OMIM:606170
name: Genitopatellar Syndrome
is_a: DOID:630 ! genetic disease

in the text there is the description, "The SBBYS variant of Ohdo syndrome (603736) is an allelic disorder with overlapping features."

but it is also not classified:
[Term]
id: OMIM:603736
name: Ohdo Syndrome, Sbbys Variant
is_a: DOID:630 ! genetic disease

so i'd think they would be grouped together in some way.

when i just browse the ontology in protege, if you look under "genetic disease" there are many things that are siblings, but have nearly identical names, suggesting they should be subclasses of a more general disease, but are instead just a big fat flat list. some examples pulled only from A:

Acyl-coa Dehydrogenase * Deficiency Of
Adams-oliver Syndrome
Adrenal Hyperplasia, Congenital
Arthrogryposis * (only 3 of the 6 are classified as subtypes)
Atrial Fibrillation (only 4 of 8 are classified as subtypes)
Atrial Septal Defect (only 4 of 8 are classified as subtypes) ...
in fact, 2257 of the omim diseases in the merged file can't be classified into any upper-level grouping class at all except for a plain "genetic disease", which isn't too helpful.

migrated from monarch-initiative/disease-miner#8

Copied from original issue: monarch-initiative/deprecated-human-disease-ontology#6

piere robin sequence synonym

From @nlwashington on May 4, 2015 4:42

Weissenbacher-Zweymüller syndrome has as synonyms Pierre Robin Malformation, Piere-Robin syndrome

PIERRE ROBIN SEQUENCE should be a synonym (should be coming from the OMIM file)

http://tartini.crbs.ucsd.edu/disease/OMIM:261800

also, it is odd to see that OMIM:261800 Pierre Robin Syndrome is a parent of itself (with same OMIM id) (see screenshot).

Copied from original issue: monarch-initiative/deprecated-human-disease-ontology#32

Ensure OMIMs have definitions

From source:

[Term]
id: OMIM:261500
name: Eosinophil Peroxidase Deficiency
def: "Eosinophil peroxidase deficiency is a rare abnormality of eosinophil granulocytes characterized by decreased or absent peroxidase activity and decreased volume of the granule matrix (summary by {9:Romano et al., 1994})." []
synonym: "Eosinophil Peroxidase Deficiency, Partial" EXACT []
synonym: "EOSINOPHIL PEROXIDASE DEFICIENCY; EPXD" EXACT []
synonym: "EPXD" EXACT []
synonym: "Peroxidase and Phospholipid Deficiency 1N Eosinophils" EXACT []
synonym: "Presentey Anomaly" EXACT []
xref: UMLS:C1850000

not showing in MONDO

chromosomal disease considerations

From @mellybelly on March 13, 2015 17:29

We have
DOID_0080014 Chromosomal disease
and
Orphanet_68335 Chromosomal anomaly

These are currently siblings, but should probably be equivalent classes. Ideally these would be inferred based upon some genetic characterization of the actual chromosomal variation. @nlwashington @mbrush can we make a property that we populate via annotations to autoclassify these in the future? We could curate these when we go through the disease annotations and add hallmark features, etc, in the new annotation tool.

The DO definition is: A genetic disease that has_material_basis_in extra, missing, or re-arranged chromosomes. Orphanet has no definition, but I like the subclasses in that they are based upon specific chromosomes. It should be easy to infer under these types with the above annotation (for example, 'partial deletion of chromosome 1')

Copied from original issue: monarch-initiative/deprecated-human-disease-ontology#13

Testing with Familial Mediterranean Fever

From @mellybelly on March 25, 2015 16:52

from monarch-app #581

ORPHANET:342 and OMIM_249100 should be merged into the one disease they are. They've got different number of annotations and likely more differences/similarities, but they're the same disease.

In addition there is another OMIM record for FMF which is autosomal dominant.

Be sensible to have these rationally connected.

Copied from original issue: monarch-initiative/deprecated-human-disease-ontology#23

Cleft palate

From @cmungall on August 8, 2015 19:11

We have:

 / DOID:4 ! disease
  is_a DOID:0080015 ! physical disorder
   is_a DOID:0050567 ! orofacial cleft
    is_a DOID:674 ! cleft palate
     is_a OMIM:119540 ! Cleft Palate *** 

This is confusing for users. We deliberately are non-aggressive in merging OMIMs into DOID; the DO term is typically general, as in this case, with the OMIM sometimes referring to something more specific than it's name suggests, although this is far from clear:

  is_a DOID:674 ! cleft palate 
     is_a OMIM:119540 ! Cleft Palate *** SPECIFIC OR GENERAL? ***
     is_a MESH:C535294 ! Reardon Hall Slaney syndrome
     is_a MESH:C535622 ! Halal syndrome
     is_a MESH:C535774 ! Piepkorn Karp Hickok syndrome
     is_a MESH:C535846 ! Hay Wells syndrome recessive type
     is_a MESH:C535971 ! Coloboma, cleft lip/palate and mental retardation syndrome
     is_a MESH:C536027 ! Martinez Monasterio Pinheiro syndrome
     is_a MESH:C536179 ! Feingold Trainer syndrome
     is_a MESH:C536189 ! Ectrodactyly-cleft lip/palate syndrome
     is_a MESH:C536284 ! Iida Kannari syndrome
     is_a MESH:C536639 ! Schrander-Stumpel Theunissen Hulsmans syndrome
     is_a MESH:C536721 ! Zadik Barak Levin syndrome
     is_a MESH:C537231 ! Samson Viljoen syndrome
     is_a MESH:C537585 ! Seres-Santamaria Arimany Muniz syndrome
     is_a MESH:C537795 ! Baetz-Greenwalt syndrome
     is_a MESH:C537901 ! Bamforth syndrome
     is_a MESH:C537906 ! Baraitser Rodeck Garner syndrome
     is_a MESH:C538126 ! Kuster syndrome
     is_a MESH:C538325 ! Ho Kaufman Mcalister syndrome
     is_a MESH:C563509 ! Schilbach-Rott Syndrome Ocular Hypotelorism, Submucosal Cleft Palate, and Hypospadias
     is_a MESH:C563651 ! Kallmann Syndrome 2 with Cleft Lip or Palate
     is_a MESH:C564442 ! Cleft Palate with Ankyloglossia
     is_a MESH:C565173 ! Coloboma, Uveal, with Cleft Lip and Palate and Mental Retardation
     is_a MESH:C565256 ! Diamond-Blackfan Anemia With Microtia And Cleft Palate
     is_a MESH:C565603 ! Cleft Lip with or without Cleft Palate, Nonsyndromic, 7
     is_a OMIM:303400 ! Cleft palate X-linked
     is_a Orphanet:101023 ! Cleft hard palate
     is_a Orphanet:155878 ! Submucosal cleft palate
     is_a Orphanet:99771 ! Bifid uvula
     is_a Orphanet:99772 ! Cleft velum

Copied from original issue: monarch-initiative/deprecated-human-disease-ontology#41

Add equivalence class IDs and labels to ClinGen file

I think it would be easier for folks to review the outcomes of the report if they can see everything in EXCEL

You could take each string provided, and then in a different column show each ID and each primary label associated with it. then you can also show all the equiv classes and their IDs and labels. In a different column, add the superclass ID and label.

We might try creatively sorting or color coding the same matches for each gene or some such in the excel for easy review.

systemic/rheumatic diseases

From @nlwashington on April 6, 2015 23:4

i was poking around, and saw "Rare systemic or rheumatologic disease" (Orphanet:98023) as high-level disease cluster

i was trying to figure out what these were, since there's no definition for this term.

i came across this page:
http://www.merckmanuals.com/professional/musculoskeletal_and_connective_tissue_disorders/autoimmune_rheumatic_disorders/systemic_sclerosis.html
(in our system, http://tartini.crbs.ucsd.edu/disease/DOID:418)

in which i notice that it is considered a "musculoskeletal and connective tissue disorder". i wonder if this disease or cluster needs to be additionally classified as such? (i think it is connective tissue, but not musculoskeletal)

also i notice that when i query for 'rheumatic disease' (MESH:D012216), no diseases come with it, but it's "parent", which is identical in label except for capitalization, has loads: DOID:1575

Copied from original issue: monarch-initiative/deprecated-human-disease-ontology#28

add medgen disease id mappings

From @nlwashington on March 6, 2015 17:37

please add medgen ids to the uberdisease ontology for xrefs. these will be useful for linking with clinvar data.
http://www.ncbi.nlm.nih.gov/medgen/docs/faq/#rel

also found this possibly relevant:
ftp://ftp.ncbi.nih.gov/pub/medgen/MedGen_HPO_OMIM_Mapping.txt.gz

ftp://ftp.ncbi.nih.gov/gene/DATA/mim2gene_medgen

also see related monarch-initiative/disease-miner#5
and https://support.crbs.ucsd.edu/browse/NIF-11766

Copied from original issue: monarch-initiative/deprecated-human-disease-ontology#4

Create grouping classes via hallmark phenotypes

From @mellybelly on March 6, 2015 19:6

It would be great if we could autopopulate any missing intermediate nodes based upon anatomical classification of hallmark phenotypes. Basically, for 'Enlarged hippocampus', you know that hippocampal formation is part of 'pallium' and 'cerebral cortex'. If Enlarged hippocampus is a hallmark for a disease (for some reason in our site I don't see any diseases with mophological abnormality of the hippocampus...hm) then we'd autoclassify that disease under the seeded intermediate nodes 'abnormal pallium phenotype' and 'abnormal cerebral cortex phenotype' or some such.

Copied from original issue: monarch-initiative/deprecated-human-disease-ontology#7

Issues editing Bridge.owl file

From @nicolevasilevsky on May 6, 2015 18:46

I made a test comment and was able to save it, but now I am having issues again. :(

I tried to move one class (achoo syndrome to a child of syndrome) and it gave me an error when I tried to save, then I tried to save again and it told me the ontology had change and would l like to reload, so I said yes.

Then I closed Protege (5, beta 17) and now it won't load the bridge file:
image

Another question- do I need to open the mondo.obo file before I can open the bridge.owl file? That is what I have been doing.

Copied from original issue: monarch-initiative/deprecated-human-disease-ontology#33

We have annotations to Orphanet IDs not in ORDO OWL

From @cmungall on March 17, 2015 4:11

We have 114 Orphanet IDs for which we have HP annotation, but the ID does not exist in the ORDO OWL export.

These appear to correspond to entries with no classification. E.g.

http://www.orpha.net/consor/cgi-bin/OC_Exp.php?lng=en&Expert=139498 'Brachydactyly type D'

Should we try and classify these? E.g. this one would go under DOID:0050581 ! brachydactyly

or

Orphanet:294937 ! Brachydactyly
Orphanet:69028 ! Syndrome with brachydactyly

Copied from original issue: monarch-initiative/deprecated-human-disease-ontology#17

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.