mohamicorp / crucible-review-hook Goto Github PK

Ability to disable mergehook: Ability to create crucible reviews when creating pull requests, but do not enforce completion of crucible review to be able to merge.

It would be nice for the generated review to set up the Linked Issue field automatically based on the JIRA ticket associated with the branch in the pull request. It would even be acceptable (although less ideal) if it was a manual entry at the time of the pull request creation

Some of the error messages look ugly and aren't working that well with the new error API.

Currently there is a race condition where you can get to the PR before the crucible review has been created.

This should be handled in one of two ways:

• Wait for the review to be created before redirecting to the PR (with a timeout of course).
• Have the review panel say waiting for review to be created and update once the review has been created.

Show the completed/rejected status of crucible reviews in the pull request. Currently the plugin just show whether the review is complete or not based on whether the author is allowed to merge.

Currently the plugin checks if the review is closed before allowing a merge. Since reviews can be in the closed state and not approved, it would be better to check for approvals.

When a bibucket pull request is declined, close the associated crucible review as well. If pull request is reopened, create a new review, or re-open the crucible review (if possible).

Crucible only allows branch addition if the diff is large enough. If the diff is too large it wont allow you to add the branch. But the plugin does not catch if the branch was successfully added or not.

Use Crucible Default Reviewers Option: Ability to create Crucible reviews using the default reviewers defined in the Crucible project, as opposed to the same reviewers in Bitbucket.

We have a large number of repositories that will need to be configured to enable the plugin and map to the appropriate Crucible settings. It would be great if there was a simple REST API that would help us to automate this process.

Currently if another user that is not authenticated with Crucible tries to view the PR they wont get any error pop up. They have to look at why merge is disabled before they can figure out when they can't see any review data.

Currently the plugin will comment when any errors are occurring. This system is inconvenient because the user doesn't get instant notifications when errors are happening.

Hi

Would be great to have the same support it provides for crucible also for upsource from jetbrains.
Would love to buy it if upsource integration is added

Kind regards,
Michael

Provide the user an option to create the review but not start it. There are times when you want to edit the review details prior to starting the review. An example would be the author adding comments to add context to part of the review. You would typically want to do this prior to opening the review up for general comments.

this is for cases when crucible repository is out of sync with bitbucket repo. (And bitbucket has newer version of branch)
If it happens merging of pull request should be disabled.

Users are reporting seeing debug log statements even when debugging is turned off in Bitbucket
2017-02-24 13:11:43,271 DEBUG [http-nio-127.0.0.1-7990-exec-200] <user> @DF5KXQx791x1151170x49 tcku0z <IP>,127.0.0.1 "GET /rest/cruciblehook/latest/reviews HTTP/1.0" c.m.b.p.r.PullRequestIntegrationServiceImpl Getting review for 2017-02-24 13:11:43,272 DEBUG [http-nio-127.0.0.1-7990-exec-200] <user> @DF5KXQx791x1151170x49 tcku0z <IP>,127.0.0.1 "GET /rest/cruciblehook/latest/reviews HTTP/1.0" c.m.b.p.crucible.CrucibleServiceImpl Getting application link. 2017-02-24 13:11:43,277 DEBUG [http-nio-127.0.0.1-7990-exec-200] <user> @DF5KXQx791x1151170x49 tcku0z <IP>,127.0.0.1 "GET /rest/cruciblehook/latest/reviews HTTP/1.0" c.m.b.p.crucible.CrucibleServiceImpl Getting review url 2017-02-24 13:11:47,939 DEBUG [http-nio-127.0.0.1-7990-exec-198] <user> @DF5KXQx791x1151224x33 1gd1fi <IP>,127.0.0.1 "GET /rest/api/latest/projects/ENTERPRISE_CTP/repos/cbg/pull-requests/755/merge HTTP/1.0" c.m.b.p.crucible-review-hook.spring BeforeInstantiation [bean=com.mohamicorp.bitbucket.plugin.hook.CrucibleMergeHook, type=com.mohamicorp.bitbucket.plugin.hook.CrucibleMergeHook] 2017-02-24 13:11:47,940 DEBUG [http-nio-127.0.0.1-7990-exec-198] <user> @DF5KXQx791x1151224x33 1gd1fi <IP>,127.0.0.1 "GET /rest/api/latest/projects/ENTERPRISE_CTP/repos/cbg/pull-requests/755/merge HTTP/1.0" c.m.b.p.crucible-review-hook.spring AfterInitialisation [bean=com.mohamicorp.bitbucket.plugin.hook.CrucibleMergeHook, type=com.mohamicorp.bitbucket.plugin.hook.CrucibleMergeHook]

A refresh button to retry review creation if there were any errors would make things a lot less tedious.

I recreated the application link and the link itself seems fine. I did realize that I didn’t turn the crucible hook settings on for the repository though. When I turned it on and tested it out, I now see the link where the review should be, but is says No Review and there’s a red exclamation icon that says “Review data not found”. I found that this comment was in the pull request:

Crucible cannot authenticate your account.
Click here to authenticate.

I clicked the link to authenticate, then recreated the pull request and the review was created. So I think we’re back online.

Is there any way that you can catch that authentication error in the plug in and let the user handle it without needing to recreate the review?

The current authentication and application link system is very clunky. It would be nice to streamline this so users don't run into errors like this again.