Giter Club home page Giter Club logo

Comments (3)

geoffreyp avatar geoffreyp commented on June 26, 2024

All components are not compatible with each algorithm because they have some requirements.
For example :

  • moead_framework.core.sps_strategy.sps_dra.SpsDra needs the attribute pi
  • SpsRandomAndBoundaries needs the attribute number_of_subproblem
  • The multi-point Crossover needs 2 solutions as parents so we have to use a mating selector that give us 2 parents
  • ...

I added more information in the documentation and I improved errors to say how the component ... is not compatible with the current algorithm. PR #66

from framework.

sjvrijn avatar sjvrijn commented on June 26, 2024

Thanks for elaborating that not all components are expected to work together. Here are my suggestions to address this issue:

  • Fix numerical and combinatorial Moead
    Lines 68 in combinatorial and 65 in numerical Moead still need to initialize the selector with parent_selector(algorithm=self)

    The if-else block may even be simplified to the example below for the combinatorial, and equivalently for the numerical case:

if parent_selector is None:
    parent_selector = TwoRandomParentSelector
self.parent_selector = parent_selector(algorithm=self)
  • Documentation:
    In the global documentation, I would add a clear generic note stating something like

    Note: Not all available components are compatible with each other.
    Refer to each component's documentation for more details on required attributes.

    at the Tutorials / Implement own algorithm and Library Reference / Other components pages

  • Exceptions:
    I'll post my explicit suggestions in the PR you already opened

from framework.

geoffreyp avatar geoffreyp commented on June 26, 2024

Thank you for your suggestions !
The PR is updated with the commits 233c694 and de0285d

from framework.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.