Disambiguate usage of the word 'generate' for Problems about framework HOT 4 CLOSED

Thank you for the PR !

from framework.

I agree.

from framework.

I understand the confusion but all the code is based on one function that creates an object OneDimensionSolution with the decision vector and the objective vector and it is not easy to refactor this part.

I propose other changes :

• rename def generate_solution(self, array, evaluate=True) by def create_solution_object(self, decision_vector, evaluate=True)
• rename the attribute solution by decision_vector as I said in the issue #44
• Specify in the documentation that we consider the Solution object as an object with a decision vector and an objective vector

The word "generate" is used for me in this context to designate the creation of the object and not the generation of the decision vector, so I understand that the documentation must be more precise

from framework.

The name create_solution_object(array) suggests that the main function of that method is to perform the action

solution = OneDimensionalSolution(array)

Wrapping that in a separate function just makes it needlessly complicated.

In PR #58, I've implemented my proposed change of removing generate_solution() and introducing evaluate(), leaving out the change to generate_random_solution. This turned out to be easier than I too had expected. You can see in the usage in the algorithm and tests that end result of the refactor outside of the Problem classes is just a rename from generate_solution to evaluate🙂

I approve of your remaining suggestions, i.e., renaming Solution.solution and further clarifying the documentation.

from framework.