Start menu app Jumplist menu not working. about modernflyouts HOT 62 CLOSED

Yes, I am sure it doesn't work. I just tried.

Also, when the app updated, I havent restarted the app. Maybe this might be an issue?

from modernflyouts.

I Made some improvements to it in a468d95

I'm closing this issue as it seems to be fixed 😅. Feel free to reopen it or notify me if anyone experience this bug.

from modernflyouts.

@Cyberdroid1 ability to hide tray icon is planned for V0.8.0 😊

from modernflyouts.

Maybe you can try adding support for command line arguments the .exe file of app. Have a look at TaskBarX for this.

Link -- https://github.com/ChrisAnd1998/TaskbarX

from modernflyouts.

Yup! I just forgot to close this issue.

After a long time, this issue is finally fixed now 😌

from modernflyouts.

Thanks for reporting, I'll look into this

from modernflyouts.

Yes, the app is already running. I can assure on that.

from modernflyouts.

Then this must be a bug and should be fixed. Thanks for submitting this issue 😁

from modernflyouts.

I tried restarting. It is still not opening the settings from jumplist.

from modernflyouts.

Its strange - that also is not working now.

from modernflyouts.

Yup, tray icon is working normally.

from modernflyouts.

Do I try reinstalling the app?

No need for that. Just wait until v0.5.0

from modernflyouts.

Ok sure. I will wait. Thanks.

from modernflyouts.

Yep I just noticed it 😅. Fixed it locally, will push once done

from modernflyouts.

Done! 44e2781

from modernflyouts.

Yes, I was thinking the same.

from modernflyouts.

Hi @ShankarBUS, still doesn't work for me. Could just be my computer. Can someone else test this to verify.

from modernflyouts.

i don't get any of the message boxes, but the jump list works.

from modernflyouts.

So the JumpList has been fixed, right?

seems so :)

from modernflyouts.

@ShankarBUS this is fixed now isn't it.
just tried it, it opened the settings menu, but got the black screen crash. #116 #12

from modernflyouts.

Ooooooff

from modernflyouts.

@ShankarBUS this is fixed now isn't it.
just tried it, it opened the settings menu, but got the black screen crash. #116 #12

OMFG! It works?
Well I didn't do anything recently TBH. The .NET 5 migration could've fixed it 🤷‍♂️. I'm surprised that it even works with the store version (0.7.1).

Ok, I checked also. Settings open up from there. But now there are some problems.

1. The settings window is never in focus. Always hidden behind any other window/maximised window.
2. Each and every option just opens up the settings! Clicking exit in context menu also opens the Settings menu. Same case with restore defaults!

I'm aware of "1" (aware of it since v0.2, just lazy to fix it 😅. Could you open a new issue so that I don't forget it?). I just noticed "2" is a thing 😅. Will try to fix it ASAP.

But "2" doesn't occur if the app is not running on the background. It only happens when they are clicked while the app is running. Thanks for noticing and reporting it 😁.

from modernflyouts.

@Cyberdroid1,

That's how the jumplist tasks already work!

Look at this one for example
https://github.com/ShankarBUS/ModernFlyouts/blob/9f161c858539cf7557fa04e6f650ba58dc8ba293/ModernFlyouts/JumpListHelper.cs#L25

There are some problems parsing the arguments passed through the named pipes.

https://github.com/ShankarBUS/ModernFlyouts/blob/9f161c858539cf7557fa04e6f650ba58dc8ba293/ModernFlyouts/Program.cs#L56

I guess I messed up the parsing method during the .NET 5 migration.

As I now know that the method work fine. I'll invest my time and work in this 😉.

from modernflyouts.

I didn't explicitly state that this app supports command line args since it is hard to find the exe location in a packaged app (the path will contain some random bullshit).

But we do support some arguments. (3 to be precise)
You can see what args are supported on here - https://github.com/ShankarBUS/ModernFlyouts/blob/9f161c858539cf7557fa04e6f650ba58dc8ba293/ModernFlyouts/JumpListHelper.cs#L10

from modernflyouts.

it is hard to find the exe location in a packaged app (the path will contain some random bullshit).

It is hard, but it ain't impossible. The package name remains static all throughout. I believe you know where to find the exe file.

from modernflyouts.

@Cyberdroid1,

It is hard, but it ain't impossible. The package name remains static all throughout. I believe you know where to find the exe file.

Here you go bud!

from modernflyouts.

this is fixed now isn't it?
Just tried it and it works.

from modernflyouts.

Are you sure the app is already running?

The settings will only be shown when the app is already running and you select the option from the JumpList

from modernflyouts.

Hey @Cyberdroid1, I can't reproduce this bug. Are you sure it doesn't work?

from modernflyouts.

Ok, try restarting it. While the app is running in the background try the jumplist option again.

from modernflyouts.

A Tip :
You don't need to click on the jumplist to open settings. You can just start the app again (from start menu) to open settings.

from modernflyouts.

Oh my god! 😑🤦‍♂️
It is perfectly working for me! Does the tray icon work atleast?

I kinda implemented the fix locally. Will ship it in v0.5.0

from modernflyouts.

Do I try reinstalling the app?

from modernflyouts.

None of the options in jumplist are working. Not even exit.

from modernflyouts.

It will come in v0.5 then?

from modernflyouts.

Yes!

from modernflyouts.

Ok! Hoping to see it soon.

from modernflyouts.

But let this issue be open. Once you receive the update and have the desired behaviour, we can close this.

from modernflyouts.

Just packaged current code, and was going to push minor update 0.4.3 to fix this bug, but discovered that the jump list options only work if the app is closed.

from modernflyouts.

Just packaged current code, and was going to push minor update 0.4.3 to fix this bug, but discovered that the jump list options only work if the app is closed.

No they will also work while the app is running

from modernflyouts.

I didnt understand the fixes in 0.4.3.

"Audio flyouts can now be repositioned."
Couldnt we do them earlier?

from modernflyouts.

Yo Sam! That was planned for v0.5.0. These changes are not "minor". Why you didn't ask me?

from modernflyouts.

Now there's nothing left for v0.5.0. Why?

from modernflyouts.

Sorry, half a sleep. Wont push to store till V0.5 is ready

from modernflyouts.

We are gonna release v0.5.0 in 2 days. So I had to delete v0.4.3. Sorry though, there are too many UI updates left to be made.

from modernflyouts.

Hey @Samuel12321, are you sure it doesn't work even after 44e2781?

I'm 100% sure it works on my PC. Can you try it again?

from modernflyouts.

Hey @Samuel12321, I will do some changes on new test branch. Run it and tell me if a message box appears with the correct message.

from modernflyouts.

Hey @Samuel12321, I just pushed the test branch called 'jumplist'

• Fetch, pull the repo and checkout the 'jumplist' branch.
• Build, Deploy the app (Stop Debugging in VS)
• Check whether the corresponding inputs show correct results (Note : You must ignore the 1st message box which says 'Pre-processing arguments... Arguments Passed : ...', it serves no purpose)
  1. App is not running in the background:
     • Run the app from start menu (just click on the tile) -> Apps starts normally after the 1st message box (no 2nd message box)
     • Select Settings from the jumplist -> 2nd message box appears saying "First Instance - Argument passed : '/settings'; Task - Show Settings"
     • Select Restore Default from the jumplist -> 2nd message box appears saying "First Instance - Argument passed : '/restore'; Task - Restore Default Flyout"
     • Select Exit from the jumplist -> 2nd message box appears saying "First Instance - Argument passed : '/exit-safe'; Task - Exit"
  2. App is already running in the background:
     • Start another instance of the app from start menu while an instance is already running -> 2nd message box appears saying "Second Instance - Second Instance - No arguments has been passed" -> Settings Window is shown instead of doing nothing
     • Select Settings from the jumplist -> 2nd message box appears saying "Second Instance - Argument passed : '/settings'; Task - Show Settings"
     • Select Restore Default from the jumplist -> 2nd message box appears saying "Second Instance - Argument passed : '/restore'; Task - Restore Default Flyout"
     • Select Exit from the jumplist -> 2nd message box appears saying "Second Instance - Argument passed : '/exit-safe'; Task - Exit"

If you get some mismatched or incorrect or no outcomes, please make a comment with the a list of what inputs causes what outcome on your system. Make a list the one above.

from modernflyouts.

@Samuel12321,

That's impossible! 😵. Are you sure you used the 'jumplist' branch? Does every commands work properly?

from modernflyouts.

whops, must have been on the other branch. On jump lists branch everything works as listed above

from modernflyouts.

So the JumpList has been fixed, right?

from modernflyouts.

And FYI the JumpList items also show up in Windows search result. So there are no needs to pin the app tile to start. It even shows up in settings window's taskbar contextmenu

from modernflyouts.

Thanks for the verification @Samuel12321!

from modernflyouts.

Hey @Samuel12321, the issue only happens with the deployed version.

It works fine during development but after deploying it to a package (i.e. to Store or as MSIX) and installing it, results in this issue.

The bug seems to root from named pipes not working on a packaged environment. I'll reopen this as it is not fixed.

from modernflyouts.

Hey @Samuel12321,

Found out what's causing this - https://docs.microsoft.com/en-us/windows/uwp/communication/interprocess-communication#pipes

• Named pipes in packaged applications must use the syntax "\\.\pipe\LOCAL\" for the pipe name.

Named pipes in .NET by default uses the '\\.\pipe\" syntax. This what caused the inter process communication not work on a packaged app (i.e. only after deployment, works fine during development) and thus rendering the jumplist tasks useless

Sorry for taking too long to find this 😅.

from modernflyouts.

all good, didn't notice it either

from modernflyouts.

No it doesn't work on the store version. Just checked v0.6.0

from modernflyouts.

After this works in v 0.7, can you please add an option to hide the tray icon?

from modernflyouts.

Ok, I checked also. Settings open up from there. But, now there are some problems.

1. The settings window is never in focus. Always hidden behind any other window/maximised window.
2. Each and every option just opens up the settings! Clicking exit in context menu also opens the Settings menu. Same case with restore defaults!

from modernflyouts.

Made a silly mistake again.

1. The Main method is not async
   https://github.com/ShankarBUS/ModernFlyouts/blob/531aa6770cce142ad09b08bb82b5de99eae2e83f/ModernFlyouts/Program.cs#L18

2. I awaited the connection https://github.com/ShankarBUS/ModernFlyouts/blob/531aa6770cce142ad09b08bb82b5de99eae2e83f/ModernFlyouts/Program.cs#L89

3. But forgot to await SignalFirstInstance https://github.com/ShankarBUS/ModernFlyouts/blob/531aa6770cce142ad09b08bb82b5de99eae2e83f/ModernFlyouts/Program.cs#L35

Thus, the second instance quits without passing the arguments which lead to an empty response (i.e. will open settings window on the first instance).

I made the SignalFirstInstance synchronous instead of making Main async and blah blah. It now works properly.

Still not sure if this will work properly on user's machine.

from modernflyouts.

Hey @Samuel12321,

What about a minor or beta release which includes 41e2dcc & 531aa67?
Could/Should we do it?

from modernflyouts.

Hey @Samuel12321,

What about a minor or beta release which includes 41e2dcc & 531aa67?
Could/Should we do it?

yes, sounds good to me.
later today i will push a 0.6.8 release to the beta ring, then if no issues to release ring.

from modernflyouts.