mnowik / ember-countries Goto Github PK

Is there any specific reason to return country names in uppercase. When I fetch the list of countries from https://github.com/mnowik/ember-countries/blob/master/addon/utils/countries-lists.js, they are in format that they supposed to be in.

Whereas, when I am trying to get the name of the country from it's ISO code using this method https://github.com/mnowik/ember-countries/blob/master/addon/utils/country-properties.js#L7, it returns the name back but transforms it to uppercase, which is not a consitent behavior.

Let me know if required, I can submit a PR for same

Installed ember-countries in my project and I am following the example given in the documentation but I am getting an error like -
" Could not find module ember imported from ember-countries/utils/countries-lists".
I am trying to import this in one of my controllers -
import { COUNTRIES_LIST } from 'ember-countries';

The ISO3 codes for Cambodia, Cameroon, Canada and Cape Verde are incorrect in the countries-lists.js file. They should be as follows:

• Cambodia = KHM
• Cameroon = CMR
• Canada = CAN
• Cape Verde = CPV

I've had a quick glance at the others, and the problem seems to only affect these 4 countries, which appear to have their ISO3 codes jumbled.

We're using the ISO3 code as a key, so it was confusing me why Canada was showing as Cameroon (CMR) etc! Thought I'd mention this in case anyone else encounters this specific issue.

Any chance this could be fixed in the next version?

Thanks

Hi there, can you update ember-cli-babel ? need a hand?

Hello,
Is there any method to list the states of given country?

Please include typescript types.

I have attached a generate set off types.

types.zip

Would you accept a PR to add template helpers for getCountry, getStatesForCountry, isCountryWithoutZip, etc.?

I don't actually use this addon anymore but I just wanted to point out that their appears to be some interest in maintaining this addon. Adopted Ember Addons was created to take over ownership of addons like this. Would you consider transferring this addon over @mnowik?

It looks like the index gets cached for the first country, and when you call getState with a second country it (incorrectly) uses the index for the first country. The cache should probably be keyed by country code.