mniebling / table-tennis-api Goto Github PK

• Return objects for players with name and nickname instead of just ids
• Don't return the points object on the match

The queued object could probably be as simple as the two/four player IDs. Perhaps also an order parameter, or could go on the order as returned in the response.

Seems like this requirement should be relaxed to allow for matches with 3 or 4 games. I get the following error when trying to post a match with only 3 games:

{
  "messages": [
    "Request parameter `games` must be an array of 5 games."
  ],
  "params": {},
  "path": "/v1/singles"
}

It will be nice to get the matches list call more slimmed down, and then if a client wants to get the points for a match they can do that on a one-off basis after #7 is implemented.

Would be nice to have wins and losses property when hitting /players/<ID>.

Or do we need to start thinking about a /stats endpoint ;]

If the id in the request params does not exist, the call returns 200 with [], which I guess is technically kind of correct, but it would be way nicer if this had an error code (maybe) or at the very least a message that the player wasn't found.

Notes:
https://stormpath.com/blog/the-problem-with-api-authentication-in-express
http://www.9bitstudios.com/2015/10/basic-authentication-in-node-js-express-applications-and-apis/

When trying to update the avatarURL of a player, both the fullName and nickname are required in the request even though they aren't being changed. Seems like it might be more convenient and less error prone to not require any fields, and only take in the fields that are being changed.