mnalis / streetcomplete-taginfo-categorize Goto Github PK

When a POI with fhrs:id closes it should be removed, it's definitely about the shop/restaurant and not the building or address.

All other fhrs:* ( fhrs:local_authority_id fhrs:authority fhrs:rating fhrs:rating_date fhrs:hygiene fhrs:structural fhrs:confidence_management ) are basically deprecated and duplicate unnecessary data. They should also be removed when a POI closes, most of the time they should be removed even when while it's open.

For example inscription

If someone made a common bad choice and mapped shop and building as one object then this tag can refer to something on building, unrelated to the shop.

In principle, support for such car could be implemented (for example asking user is given inscription still present) but it works be nasty to implement.

And for GNIS id it is even worse as there is no direct human readable form (and putting GNIS database into SC would be silly)

I won't have time to do the PR until this weekend, so this issue will serve as a reminder for me and/or if @mnalis wants to do it themselves prior to then.

streetcomplete/StreetComplete#3982 added office={telecommunication, it, lawyer, accountant} into the shop expression and the tags to remove stuff needs to be updated.

I updated isShopExpressionFragment, it now includes anything that could be in a (non-purpose-built) building, i.e. also any office, craft etc.

Right very now, it is still on the shops-overlay branch but I will merge it to master today.

Not sure what I need to do here, I'd rather leave this up to you.

"Packages No packages published" is displayed right now, fortunately this pointless section can be removed.

Edit repo page config to remove it (cog next to the description).

I am not making a PR as it is defined in proprietary github settings, not in a git repository - and I have no rights to modify repo settings.