mlms13 / bs-nonempty Goto Github PK

Studying your code, sir.

NonEmptyList.t does not tolerate updating the dependencies. Though obviously, it works with its oringal dependencies.

Here is the error, if it matters to you:

:1
  
  1 │ open BsAbstract.Interface;
  2 │ 
  3 │ module ArrayMonoid: MONOID_ANY with type t('a) = array('a) = {
  4 │   type t('a) = array('a);
  5 │   let append = Array.append;
  6 │   let empty = [||];
  7 │ };
  8 │ 
  9 │ module ArrayArrayLike: NonEmptyBase.ARRAY_LIKE with type t('a) = array(
      'a) = {
  
  Signature mismatch:
  ...
  Values do not match:
    let empty: array('_weak1)
  is not included in
    let empty: t('a)
  File "/Users/mandalarian/Github/bs-nonempty/node_modules/bs-abstract/src/interfaces/Interface.re", line 23, characters 49-65:
    Expected declaration
  File "/Users/mandalarian/Github/bs-nonempty/src/NonEmptyArray.re", line 6, characters 6-11:
    Actual declaration

Tried to think through it but here I am asking so....
Thanks for sharing.

We're already talking about adding an elem function when the inner 'a is a member of EQ. If we're adding that, we might as well also eq for NonEmpty.t in that case and make NonEmpty implement EQ.

The easiest way to check Nels for equality is probably by zipping them together, so we'll want zip and zip_with as well.

For a normal Foldable, these functions would return an option('a), but NonEmpty can guarantee you get an 'a back.

let any: (('a => bool), NonEmptyList.t('a)) => bool;
let all: (('a => bool), NonEmptyList.t('a)) => bool;
let elem: ('a, NonEmptyList.t('a)) => bool; /* where 'a is a member of EQ */
let find: (('a => bool), NonEmptyList.t('a)) => option('a);

Although theoretically most of this could live in bs-abstract and come for free with FOLDABLE.