ml-tooling / universal-build Goto Github PK

Describe the bug:
I have a project with submodules, it could be think as:

build.py
|  submodule/
|    |   build.py

I defined an argument with using an underscore in the name in both build.py

parser.add_argument(
    "--my_token" 
)

When the submodule is called from the parent, it is called with an argument --my-token which is not detected by the submodule.

Expected behaviour:
The names fo the arguments shouldn't be changed between when the parent and the submodule.

Steps to reproduce the issue:

Technical details:

• Host Machine OS (Windows/Linux/Mac):
• Browser (Chrome/Firefox/Safari):

Possible Fix:
The replacement of _ to - is here:

Additional context:

I have the following structure:

build.py
|  src/
|  |  myfile.txt

And in build.py I have the following code:

from universal_build import build_utils

build_utils.copy(
    src_path="./src",
    target_path="./target/",
    preserve_target=True,
)

When the code is run, I expect the following structure:

build.py
|  src/
|  |  myfile.txt
|  target/
|  |  myfile.txt

However I have the following structure:

build.py
|  src/
|  target/
|  |  myfile.txt/
|  |  |  myfile.txt

Two things happened that I didn't expect:

• The source file is deleted
• There is an intermediate folder with the name of the file

Issue number one I suspect comes from the use of move instead of copy here:

Issue number two I believe comes from this line:

I think a change to the parent should fix the issue but hasn't been tested.

path.parent.mkdir(parents=True, exist_ok=True)

Describe the bug:
When using the build-environment docker image as a base image and then running apt-get update it leads to the following error:
E: The repository 'https://deb.nodesource.com/node_14.x focal Release' does not have a Release file.

Steps to reproduce the issue:
Try to build the following dockerfile:

FROM mltooling/build-environment:0.6.15
RUN apt-get update

Possible Fix:
Looks like this could be due to the expired Let's Encrypt root certificate:
nodesource/distributions#1266
In that issue it is suggested to update the ca-certificates package.
This package is already installed in the build environment, so a docker build with --no-cache might already solve the problem.