mkoslacz / moviper Goto Github PK
View Code? Open in Web Editor NEWA Mosby based VIPER library for Android
License: Apache License 2.0
A Mosby based VIPER library for Android
License: Apache License 2.0
After having read JakeWharton/butterknife#585
and then looking at the module https://github.com/mkoslacz/Moviper/blob/master/moviper-butterknife/src/main/java/com/mateuszkoslacz/moviper/base/view/fragment/autoinject/butterknife/ViperButterKnifeFragment.java
I have to ask : is the unbinding missing from ViperButterKnifeFragment? It looks like it.
What do you recommend doing when you cannot extend ViperFragment or ViperActivity? Let's say I have a custom view that already extends DialogFragment, what's the approach to rigging up / binding the presenter, interactor, router? I can't seem to find a suitable sample that fits this need.
Hi,
I think I can understand why a BaseRxInteractor needs no isPresenterAttached()
logic as with BaseInteractor. However, in the case where one had a Presenter that had an addSubscription:
public void attachView(ViewInterface view) {
addSubscription(
getInteractor().getData()
.subscribeOn(Schedulers.io())
.observeOn(AndroidSchedulers.mainThread())
.subscribe(presenterData -> {
if (isViewAttached()) {
ViewModel vm = createViewModel(presenterData);
getView().updateViewModel(vm);
}
}, error -> {
if (isViewAttached()) {
ViewModel vm = createrViewModel(null);
getView().updateUserViewModel(vm);
didFailUserData(error.getLocalizedMessage());
}
})
);
}
We have found that we required similar checks for subscriber.isDisposed()
on any async work.
For example:
public Single<PresenterData>> getData() {
return Single.create(subscriber -> {
mService.getAPIData()
.subscribeOn(mJobScheduler)
// throttling logic and exponential retry logic goes here
.subscribe(
response-> {
// business logic here to parse data, filter, groom, etc
// PresenterData presenterData = doWork(response);
if (!subscriber.isDisposed()) { //check if presenter is still attached
subscriber.onSuccess(presenterData);
}
}, throwable -> {
if (!subscriber.isDisposed()) {
subscriber.onError(throwable);
}
}
);
});
}
In light of this do you think the BaseRxInteractor should have some kind of isPresenterAttached()
logic?
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.