Giter Club home page Giter Club logo

moviper's People

Contributors

jakubjodelka avatar mkoslacz avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

moviper's Issues

Sample case when using a view you cannot extend (e.g. DialogFragment)

What do you recommend doing when you cannot extend ViperFragment or ViperActivity? Let's say I have a custom view that already extends DialogFragment, what's the approach to rigging up / binding the presenter, interactor, router? I can't seem to find a suitable sample that fits this need.

Detecting if presenter is attached on a BaseRxInteractor

Hi,
I think I can understand why a BaseRxInteractor needs no isPresenterAttached() logic as with BaseInteractor. However, in the case where one had a Presenter that had an addSubscription:

public void attachView(ViewInterface view) {
        addSubscription(
            getInteractor().getData()
                    .subscribeOn(Schedulers.io())
                    .observeOn(AndroidSchedulers.mainThread())
                    .subscribe(presenterData -> {
                        if (isViewAttached()) {
                            ViewModel vm = createViewModel(presenterData);
                            getView().updateViewModel(vm);
                        }
                    }, error -> {
                        if (isViewAttached()) {
                            ViewModel vm = createrViewModel(null);
                            getView().updateUserViewModel(vm);
                            didFailUserData(error.getLocalizedMessage());
                        }
                    })
        );
}

We have found that we required similar checks for subscriber.isDisposed() on any async work.

For example:

public Single<PresenterData>> getData() {
        return Single.create(subscriber -> {
            mService.getAPIData()
                    .subscribeOn(mJobScheduler)
                    // throttling logic and exponential retry logic goes here
                    .subscribe( 
                            response-> {
                                // business logic here to parse data, filter, groom, etc 
                                // PresenterData presenterData = doWork(response);
                                if (!subscriber.isDisposed()) { //check if presenter is still attached
                                    subscriber.onSuccess(presenterData);
                                }
                            }, throwable -> {
                                if (!subscriber.isDisposed()) {
                                    subscriber.onError(throwable);
                                }
                            }
                    );
        });
}

In light of this do you think the BaseRxInteractor should have some kind of isPresenterAttached() logic?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.