mkko / drawerview Goto Github PK

Hi,
Sorry for the request-for-help disguised as an issue.

I'm trying to emulate the podcasts and itunes' app behaviors with DrawerView. This means that I have a "now playing" bar that sits on top of a tab bar, and doesn't change when you switch tabs, which can be expanded with a tap or a swipe.

To that end, I've tried attaching a DrawerView in code (in UITabBarController), trying to add layout constraints to attach the bottom of the drawer view to the top of the tab bar, but any layout constraint I add seems to get rejected immediately. I'm trying this:

class TabBarControllerWithDrawer : UITabBarController {

   override func viewDidLoad() {
        let drawerView = DrawerView()
        drawerView.attachTo(view: self.view)
        drawerView.snapPositions = [.collapsed, .open]

        NSLayoutConstraint(item: drawerView, attribute: .bottom, relatedBy: .equal, toItem: self.tabBar, attribute: .top, multiplier: 1, constant: 0).isActive = true
}

Am I totally on the wrong track? Should I instead be just attaching a shared instance of DrawerView to each of the tab's children? Some other method?

Thanks,
Ben

For a workaround, I have to move 'drawerView.topMargin = 354' behind 'drawerView.overlayVisibilityBehavior = .disabled'

Hello, first thanks so much for creating this framework, it's been very useful in my project.

I searched the documentation and code, but I didn't find it.

How do I turn off this animation that makes the top part dark when I scroll the drawer to the top of my screen? it's possible?

Following definition of "third-party SDKs" that as mentioned in the WWDC23. and according to Privacy manifest files | Apple Developer Documentation, I think this library may also require a Privacy Manifest for the upcoming app review in Spring 2024.

Do you have any plans to add a Privacy Manifest or to have a claim that this library actually does not need a Privacy Manifest?

Thank you very much!

Hello!
There's this annoying bug that prevent to scroll the drawer up and down, unless you put the finger on the table view inside it. This happens only on iOS 13.
I think it's pretty urgent. Do you think you're able to release a fix soon?

Thanks.

Fatal Exception: NSInternalInconsistencyException
It is an error to release a paused or stopped property animator. Property animators must either finish animating or be explicitly stopped and finished before they can be released.
DrawerView.scrollToPosition(_:animated:notifyDelegate:completion:)

DrawerView.swift - Line 582
DrawerView.scrollToPosition(_:animated:notifyDelegate:completion:) + 582

Any chance you could make the DrawerView class open this would allow extending it and setting up the view within a subclass itself.

Love this project, but it looks like the cocoapods version is missing some critical new features, for example, overlayBackgroundColor. Can you please update? Thanks!

First of all thanks for your great work!

I have a problem when panning the drawer.
In your example project the drawer grows and shrinks when panning up or down.
In my app nothing happens when I start panning. Only when the panning finishes the drawer opens or collapses.

Do you have an idea what I'm doing wrong?

Here is how I'm adding the drawer:

` boxMapDrawerViewController.view.cornerRadius = 8

    drawerView = addDrawerView(withViewController: boxMapDrawerViewController)
    drawerView?.snapPositions = [.open, .collapsed]
    drawerView?.setPosition(.collapsed, animated: false)
    drawerView?.collapsedHeight = 130
    drawerView?.backgroundEffect = nil
    drawerView?.shadowRadius = 20
    drawerView?.shadowOpacity = 0.25

`

The boxMapDrawerViewController only contains a one simple UIView, I also tried one with a scroll view inside. It does not make a difference adding the drawer in loadView or viewDidLoad.

I can't see what I'm doing different in comparison to your sample app.

Btw, I'm using Xcode 10.2.1, Swift 5 and deployment target is 12.0. Version of DrawerView is 1.1.1.

I have a DrawerView with a descendent UITableView inside a containerView. That tableview extends under a sibling header view so that the header can be collapsed to reveal more of the tableview on scroll. (Similar to how Apple collapses the Navigation Bar to show more content when you scroll).

To achieve this I set a contentInset for the top of the tableview so content can be fully exposed while the header view is fully expanded.

tableview.contentInset = UIEdgeInset(top:175, left:0, bottom:view.safeAreaInsets.bottom, right:0)

However, DrawerView's handlePan() is not taking the content inset into account when determining if there is more content in the scrollview to be shown

The fix is to change the line 810 in DrawerView:

let childReachedTheTop = activeScrollViews.contains { $0.contentOffset.y <= 0 }

to:

let childReachedTheTop = activeScrollViews.contains { $0.contentOffset.y <= -$0.contentInset.top }

and this also necessitates a change to line 837:

let minContentOffset = activeScrollViews.map { $0.contentOffset.y }.min() ?? 0

to

let minContentOffset = activeScrollViews.map { $0.contentOffset.y + $0.contentInset.top}.min() ?? 0

Happy to make a pull request with the fix, but need to take a look at the unit test setup you have first, if it even something you'd want to add a unit test for.

Great component BTW!

The Overlay wasn't working when accessibility voice over enabled.

As per the native methods the Overlay enable the accessibility in order to work as normal when voice over enabled.

Please enable the accessibility for Overlay view class

isAccessibilityElement = true

Would be nice for DrawerView (which is amazing btw) to support swipe to dismiss for WKWebViews. Would also be nice if WKWebView was a subclass of UIScrollView!

Hi,
First of all, thank you for providing us a great tool, here is the issue I am facing when I am adding a Horizontal collection view as a subview of a drawer view When I am trying to scroll the collection view drawer gets changed its states.

It seems that in the most recent version of your code, the ability to horizontally scroll when the DrawerView is in any other position but open does not work.

I noticed that this functionality is part of your demo app, but it does not function outside of your demo app.

Can we get a new tagged release, please?

In our project we're using an internal fork - but the fixes we made are already backported to the main repo and merged in. We'd like to ditch the fork, but we're not comfortable doing this unless there's a tagged release (we don't want to put a commit hash in a Podfile).

Any chance of getting current version released?

This hasn't produced a crash for me, but I thought you'd like to know anyway in case someone else does run into a related bug. I found this while profiling my own app. Let me know if you need any more info!

Version

Installed using pod 'DrawerView', '~> 1.3.1'

Profiler Screenshot

Identified Line

I have a need to override some functions for customization. However Xcode won’t let me do this because: ‘Cannot inherit from non-open class (DrawerView) outside of its defining module’.

Could you please declare DrawerView as ‘open’ instead of ‘public’?

I'm having trouble with disappearing DrawerView. I have a scrollable UITableView as DrawerView's subview and it generally works fine, but sometimes when its collapsed it just disappears when I drag it down...its there but becomes invisible(not changing alpha or hiding it anywhere)..

In order for it to show I have to drag it up from collapsed position(even though I don't see it) and it will appear again.
It's been bugging me for a while and I don't know how to solve it.

Any ideas if I could be doing something wrong with setting up the DrawerView?

In any case, great job creating the DrawerView and thank you.

Hello!
Congratulations for the very cool and useful library!

I'm facing an issue, related to the swipe to delete. I have a UITableView into the drawer and the user should be able to delete cells swiping. This is not working good as the drawer is easily draggable. Is there a way to adjust the sensibility of the scroll? Or is there another way?

Just diving into this bug I have found. In my app, I want to change logic depending if the user has swiped the drawer closed. I basically pop up a UI element that allows them to reopen the drawer since closed in my app is completely closed. I have this logic in the drawer(_ drawerView: DrawerView, didTransitionTo position: DrawerPosition) delegate method checking if position == .closed. I have found that if the user swiped multiple times in quick succession, this delegate method will not fire even though the drawer does indeed transition to the .closed position. willTransitionTo does fire, so as a workaround I am changing to listen to that.

Steps to reproduce:

1. Clone and run DrawerViewExample app
2. Run the app on a physical device (easier to reproduce this way, but can also happen in sim)
3. Swipe the drawer up multiple times in quick succession
4. Observe console logs

Expected: (These logs are from swiping up once)

drawerWillBeginDragging
drawerWillEndDragging
drawer(_:willTransitionFrom: partiallyOpen to: open)
drawerView(_:didTransitionTo: open)

Actual:

drawerWillBeginDragging
drawerWillEndDragging
drawer(_:willTransitionFrom: partiallyOpen to: open)
drawerWillBeginDragging
drawerWillBeginDragging
drawerWillBeginDragging
drawerWillBeginDragging

In collecting these logs, I notice that there are several drawerWillBeginDragging events without corresponding drawerWillEndDragging events. Perhaps this is a good starting point.

Hi,

first of all thanks for your great work!

After updating from version 1.2.0 to 1.2.1 I'm getting a crash when calling

drawerView?.insetAdjustmentBehavior = .fixed(AppDelegate.shared.window?.safeAreaInsets.bottom ?? 0)

It does not matter calling this in loadView() or viewDidLoad().

Do you have an idea why this happens?

Thank you very much for creating this drawer. Really useful for my project.

The only thing I'm having a bit of trouble is when I'm displaying the drawer in a collapsed state. The constraints are different when viewing it in an iPhone X.

I have the top constraints to 5px in my drawer view controller. It looks fine on an iPhone 8 Plus but seems to look different on the iPhone X. I have also tried to set the constraints to the safe area and the superview to see if there's a difference but got the same result.

Do I need to update or adjust the constraints when I add the drawer view with the view controller I created?

This is awesome. I don't have a full screen view. Can we specify a hight for .open state as well, if so how?

I'm not sure when Apple changed this, but recently when porting older code I've had to update from just import Foundation to import UIKit. Seeing this in DrawerPresentation.swift

I use the DrawerViewto host my SwiftUI views like so:

VStack{
  ScrollView(.vertical){
    ScrollView(.horizontal){
      AnyView()
    }
  }
}

Trouble is, unless I scroll perfectly horizontally, the drawer view tries to close/open if my finger moves up or down slightly.

This will even happen when the parent ScrollView(.vertical) is scrolled to the bottom, meaning I will end up with a collapsed drawer view but the ScrollView(.vertical) won't be scrolled to the top.

Hello, i can't horizontal scroll in collectionView - drawerView starts to change position, when i try scroll collectionView. I need to scroll the collectionView in any position

Thanks for your great work!, I think visual effect should be disabled by default unless we turn on it. In my drawer view, i need to make the background color to be clear, and the visual effect is messing up even I set backgroundEffect to nil

When the view is presented for the first time and it has a cornerRadius, it animates it as if it is shaving off the corners.

Hello @mkko! I have a question. Is it possible to insert drawer below specific view?

I have UITabBarController with some items inside it. I want to present drawer below UITabBar but on front of my UIViewControllers.

Hi, I have a drawerview which contains two views embedded in a UIScrollView.
There is an UISlider in the first view, how can I stop the drawer scrolling when I panning the UISlider back and forth?

Hello,

My team is interested in using this library but we are also looking to upgrade our codebase to Swift 5 (using Swift 4.2 currently). Will this support projects that are running Swift 5? I ran the Swift 5 conversion tool that Xcode provides and there were a couple changes made in DrawerView.swift, mainly around the firstIndex calls.

Thanks.

Hi and thank you for DrawerView 😊
I've noticed that the drawer view has rounded corners even at the bottom when it's fully expanded

So I'm using the drawer as a "Settings" view, and it is pulled up over a CollectionView. When I open the Settings drawer, if I had scrolled at all in the CollectionView beforehand, it scrolls it back to the top. Any way to fix this?