Please expose the json conf reading function about cli HOT 6 CLOSED

So easy to read json file:

func (p JSONFileParser) Parse(s string) error {
    f, err := os.Open(s)
    if err != nil {
        return err
    }
    return json.NewDecoder(f).Decode(p.ptr)
}

from cli.

Hmm..., agree, it's easy to read json files. I'm just thinking, from the completeness point of view, CLI should expose how to update the CLI structure from json files, giving it a standard so that everyone can following, not everyone doing it in their own ways.

BTW, you demo code only deals with json file, but you've left out how to update the CLI structure from json file right?

from cli.

I add functions: ReadJSON and ReadJSONFromFile

func ReadJSON(r io.Reader, argv interface{}) error {
    return json.NewDecoder(r).Decode(argv)
}

func ReadJSONFromFile(filename string, argv interface{}) error {
    file, err := os.Open(filename)
    if err == nil {
        err = ReadJSON(file, argv)
    }
    return err
}

Both two can update argv from json data.
See commit 617d581

from cli.

Thank you VERY MUCH!

from cli.

It doesn't really matter but it is better to close the file in ReadJSONFromFile().

Ref: https://github.com/go-jsonfile/jsonfile/blob/master/jsonfile.go

Note the line,

// Credits: Mkideal Wang https://github.com/mkideal/cli/issues/22

from cli.

Thanks!

from cli.