Giter Club home page Giter Club logo

Comments (19)

suntong avatar suntong commented on June 10, 2024

For details about the fix,

Refer to https://github.com/go-easygen/wireframe/wiki/UsageStyle-of-package-cli

from cli.

mkideal avatar mkideal commented on June 10, 2024

How should I merge these changes?

from cli.

suntong avatar suntong commented on June 10, 2024

Oh, ..., seeing that you are redoing everything, I thought you'll be continue along that path.

Now that the two repos have diverged, there is no longer any easy way to merge them.

If I were you, I'd

  • revert to the point before the diverge, while keeping all your new changes in the history.
  • then merge automatically all the changes me and meisterluk made, from https://github.com/go-easygen/cli's master
  • then fix any thing that are not done correctly, like #37, etc.

Otherwise, I see no way unless redoing everything manually.

from cli.

suntong avatar suntong commented on June 10, 2024

If the above all seems too complicated, I can help with my part. I.e., we divide and conquer -- I do the merge part you do the afterward-fixing. Alright?

from cli.

mkideal avatar mkideal commented on June 10, 2024

Alright. thx

from cli.

suntong avatar suntong commented on June 10, 2024

OK. Will do this weekend.

It's a huge change, so please review what I proposed again so that you completely understand what I'll be doing. If have any doubts, please let me know ASAP, as the least thing I want is to have my hard efforts rejected due to some misunderstanding.

Just to make sure. Pls confirm. Cheers.

from cli.

mkideal avatar mkideal commented on June 10, 2024

What issues are included in these changes? Just #42#43?

from cli.

suntong avatar suntong commented on June 10, 2024

Well, actually I was talking about auto-merging all those changes that enhanced in the temp repo (ref: change log) since the cli dormant stage, done by meisterluk (committed on Jan 14) and me. Ref: #47.

That's why I said it's huge.
This is the only way to do auto-merging.

Otherwise, I see no way unless redoing everything manually.

Thus, please think twice.

from cli.

suntong avatar suntong commented on June 10, 2024

Hold on, maybe there are ways to cherry-pick what to merge back, but I've never done it before.

So now I'm thinking the best approach is for you to cherry-pick from the enhanced temp repo back to cli, since I've never done it before either (else, I can auto-merging all those changes for you).

Still the very first step is still to revert to the point before the diverge (while keeping all your new changes in the history).

from cli.

mkideal avatar mkideal commented on June 10, 2024

Maybe you can create a PR, then I merge it.

from cli.

suntong avatar suntong commented on June 10, 2024

Yeah, that's the plan. You meant PR that auto-merging all those changes right?

from cli.

mkideal avatar mkideal commented on June 10, 2024

You meant PR that auto-merging all those changes right?

Maybe I need to manually merge to resolve conflicts

from cli.

mkideal avatar mkideal commented on June 10, 2024

Please wait. I try manually merge first.

from cli.

suntong avatar suntong commented on June 10, 2024

sorry, you always only say half the sentence. I never know exactly what you plan is.
I'll stop chasing you around asking followup and confirmation questions.

So unless I got clear instruction from you what I should do, I'll assume you will be doing everything.
If you need my help, please describe exactly what I should do.

thx. G'd night.

from cli.

suntong avatar suntong commented on June 10, 2024

Ah, saw you update. Good, I'll leave it with you...

from cli.

mkideal avatar mkideal commented on June 10, 2024

Finished! See commit 7858d40

from cli.

mkideal avatar mkideal commented on June 10, 2024

NOTE: I have not used your submission for #40. See #40 for details

from cli.

mkideal avatar mkideal commented on June 10, 2024

I made a mistake!I push commits to go-easygen/cli, >..<

from cli.

suntong avatar suntong commented on June 10, 2024

NOTE: I have not used your submission for #40. See #40 for details

Yep, understood.

I made a mistake!I push commits to go-easygen/cli,

And now you've fixed it, :)

from cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.