mkcn / fasthistory Goto Github PK

"f --export" command failed if db does not exist.

E.g.
INFO:root:export output: /home/runner/work/xx/xx/fastHistory_2020-03-22.db
ERROR:root:export database error: [Errno 2] No such file or directory: '/home/runner/.local/share/fastHistory/fh_v1.db'

'' '/' '%' '$' chars should be allowed in the description field

The current default level for logs is NOTSET.
The goal was to disable logs with this, but due to a incorrect interpretation of the value we now have log enabled in full mode by default.

More info: https://docs.python.org/2/library/logging.html#levels

FastHistory currently uses only the common and linux pages. (https://github.com/tldr-pages/tldr/tree/main/pages)
It should use also windows , osx and sunos based on the OS where it runs.

the ReDos attack works in Ubuntu 16.04.
To reproduce, execute the following UnitTest:

• fastHistory/unitTests/test_databaseSQLite.py --> test_input_regex_attack

Project: https://github.com/tldr-pages/
This will allow to have the most common commands already available in fastHistory

fastHistory will automatically check the used OS and it will filter them for Linux, macOS or Windows

1. filter the list for tag X
2. Show more for one of the filtered items
3. Edit tags
4. Remove tag X
5. the page now shown is wrong

Tested with current master

Provide a bash script to install the tool with one line.
Alternatively test and use pip.

I don't understand how to use "Canc" :P. Maybe another description is needed ?

Currently fastHistory works completely offline.
All commands can be manually exported and imported on a different computer.

We could add a service that run in background to make a real-time sync of all stored commands.
This require also to expose some API, to define an account flow for user accounts and to provide some sort of data redundancy server side.

• open new tab
• press "ctrl+c"
• the last command in the history is read by fastHistory as user input (e.g. "# ls -ls #")

1. go to Discover tab
2. select an command
3. select an example
4. resize the windows in a way the selected example is out of screen
5. see the error

With a small change of the "f.sh" file zsh can be supported.
The ".zshrc" must be also changed.

Multi-lines commands are currently ignored

Example:

echo "string1
string2
string3
" #print #multi-line

is interpreted as

echo "string1

When there is no tag and you edit the description of a command the cursor is on the wrong line

Each line of the log file shows the type, user and message

INFO:root:import database: 92 elements imported

The user could be removed and the date added as first column.

The length of tags, descriptions and commands should be check before to insert them into the database

Commands that contain the "#" char behave correctly but an error is shown in the console

Example:

echo "# 2" > t

echo "test#" 

The command "man " on windows takes a couple of seconds and the UI is not responsive

To update fastHistory it will be enough to type "f --update" and it will automatically inject the needed command into the terminal.

E.g. for pip3
"pip3 install -U --no-cache-dir fasthistory && $HOME/.local/bin/f"

When a command is selected, there should be a quick way to copy it into the clipboard instead of injecting it into the terminal.

Example of usage: the command is not needed for the current machine

In python 3.8 the following warning is shown:

2020-03-10T08:38:37.2701777Z /home/runner/work/fastHistory/fastHistory/fastHistory/parser
/inputParser.py:234: SyntaxWarning: "is" with a literal. Did you mean "=="?
2020-03-10T08:38:37.2702595Z elif string is "":
2020-03-10T08:38:37.2703067Z /home/runner/work/fastHistory/fastHistory/fastHistory/database/databaseSQLite.py:469: SyntaxWarning: "is not" with a literal. Did you mean "!="?
2020-03-10T08:38:37.2703637Z if new_description is not None and new_description is not "" and new_description != old_description:
2020-03-10T08:38:37.2704115Z /home/runner/work/fastHistory/fastHistory/fastHistory/database/databaseSQLite.py:470: SyntaxWarning: "is" with a literal. Did you mean "=="?
2020-03-10T08:38:37.2704540Z if old_description is "":
2020-03-10T08:38:37.2705009Z /home/runner/work/fastHistory/fastHistory/fastHistory/database/databaseSQLite.py:550: SyntaxWarning: "is" with a literal. Did you mean "=="?
2020-03-10T08:38:37.2705443Z if new_cmd is None or new_cmd is "":
2020-03-10T08:38:37.2705880Z /home/runner/work/fastHistory/fastHistory/fastHistory/pick/pageGeneric.py:76: SyntaxWarning: "is not" with a literal. Did you mean "!="?
2020-03-10T08:38:37.2707169Z if index_sub_str is not -1:

The "f-add test & #" command generates double entries

Using "f --log" should inject the following command into the terminal:

nano {installation_folder}/fh.log

This will help to debug issues or to simply find the log file