Error with generated custom component when rendering MJMLElements about mjml HOT 6 CLOSED

Hi @epayet, thanks for reporting. We'll look into it and come back to you with a solution.

Thanks for your patience!

from mjml.

Hi @epayet ,

If mj-product is empty, content is empty so the engine crash. I'll try to fix it today

from mjml.

Hi,

Sorry to reopen this issue but the bug isn't resolved even with the version 1.2.0
I made a small repo with the reproduction of this bug: https://github.com/epayet/mjml-bug-component

I cannot see why it is still happening. Could you look into it?
I am happy to help. Thanks

from mjml.

Ok, I figured out what happen: When giving a non-react element to a mjText that depends on mjContent it will crash.

Thank you very much for taking the time to do a repository to reproduce the bug ! I'll try to get a fix for a next release !

from mjml.

Cool that would be awesome, I ran into exactly the same issu. A slight adjustment to the mjContent method solved it

    mjContent() {
      const content = this.state.getIn(['elem', 'content']);
      if ( content ) {
        return _.trim(content)
      }
      return React.Children.map(this.props.children, child => {
        if (typeof child === 'string') {
          return child;
        }
        return ReactDOMServer.renderToStaticMarkup(child)
      })
    }

from mjml.

👍 @rogierslag if you can open a PR would be so cool ! :)

from mjml.