Comments (4)
iRyusa
commented on August 16, 2024
Can you maybe share a snipper to reproduce because I don't see any issue on my end
from mjml.
jjbindr
commented on August 16, 2024
Thanks for the response. my bad. looking at the documentation closer I see it is plural, not singular keepComments
from mjml.
jjbindr
commented on August 16, 2024
The behavior is a little strange though. It seems to be dependent on where the comments reside in the mjml code. Not all are getting kept. See attached.
I placed 4 comments only 2 are getting kept.
Command:
npx mjml templates/admin-invite.mjml -o generated --config.keepComments=true
from mjml.
iRyusa
commented on August 16, 2024
MJML to HTML wont be transpiled 1-to-1 ex here :
https://mjml.io/try-it-live/W6zfrfYKXg
That's why it behave like that. I know that's not super intuitive as HTML
document dont work like that, but given how MJML document are parsed,
there's no so much to do here
… Message ID: ***@***.***>
from mjml.
Related Issues (20)
- Extra quotes in CSS url() from <mj-section /> background-url HOT 9
- <!--[if !mso]><!--> mso conditional statement not being exported correctly HOT 2
- mj-columns in gmail looking as mobile view not flexed HOT 1
- mj-include tag throwing errors on style import and imports in the head tag HOT 5
- Image width in outlook is overflowing HOT 2
- Issues with rendering in outlook HOT 1
- DeprecationWarning: The `punycode` module is deprecated on node 21 HOT 2
- "try it live"-Function now not working any more HOT 1
- New Twitter X logo not being rendered with <mj-social-element name="x" href="#"> HOT 1
- Just the basics HOT 3
- Navbar without hamburger unnecessary css HOT 1
- `mj-font` only emits the last style sheet for the font family HOT 1
- Font sizes increase in Gmail on iPhone XS HOT 6
- Append invisible characters to <mj-preview> HOT 1
- CORS request did not succeed, missing CORS header (mjml/api) HOT 2
- `mjml2html` render in web worker throws `Uncaught ReferenceError: window is not defined` HOT 2
- Support DATA variable in href or button HOT 1
- Icon with text/Column within Column HOT 1
- Dependency: html-minifier REDoS vulnerability HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mjml.