Giter Club home page Giter Club logo

Comments (4)

zhijian-liu avatar zhijian-liu commented on May 18, 2024

They are the same as the computation overhead introduced by the point-based is not that significant. The overhead can also be observed in this figure actually (there is a small shift in the x-axis between MinkowskiNet and SPVCNN).

from spvnas.

chaitjo avatar chaitjo commented on May 18, 2024

Thanks for the response. I see, indeed, I can also see the small shift!

  1. Based on Haotien's response here: #19, I got the impression that voxelization/devoxelization procedure in SPVCNN will have some impact on MACs and GPU latency when compared to MinkowskiNet at the same cr? (B/c the sparse convolution branches are exactly the same in both nets.) Am I correct in my understanding that the penalty for voxelization/devoxelization procedure actually does not penalize the model's inference time much, esp. at small cr?

  2. This raises another Q. to me: at the same cr, e.g. cr=1.0, shouldn't the number of trainable parameters in MinkowskiNet be lower than the corresponding SPVCNN? (B/c SPVCNN uses point transformation MLPs whereas MinkowskiNet does not.) However, in the pre-trained models you released, both models seem to be equal in number of parameters; am I missing something?

from spvnas.

zhijian-liu avatar zhijian-liu commented on May 18, 2024
  1. I think your understanding is correct. The voxelization and devoxelization will indeed introduce some overhead. However, as we are doing them once per several layers, the overhead can be amortized.
  2. You are right. From https://github.com/mit-han-lab/e3d/blob/master/spvnas/core/models/semantic_kitti/minkunet.py#L149-L165, you may see that we have also defined the point transforms for MinkowskiNet although we are not actually using them. We will remove them to resolve the confusion.

from spvnas.

chaitjo avatar chaitjo commented on May 18, 2024

I see, that clarifies it. Thanks!

from spvnas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.