mistermicheels / current-task Goto Github PK

On Mac, when using dark mode, there is a black border around the main app window:

It seems that this is a bug in Electron/Chromium/macOS that is outside our control. Relevant Electron issue: electron/electron#13164

The good news is that the border only stands out against a light background, which should be the exception rather than the rule in dark mode. Example of how it looks against a dark background:

Reproduction scenario:

• Set up two screens
• Make sure they have different scale factors (for example, primary at 125% and secondary at 100%)
• Start the app
• Make the app switch to nagging mode and back
  • Result: everything should still be fine
• Move the app window to the secondary screen
• Make the app switch to nagging mode and back
  • Result: window placement is off, both for nag screen on primary and normal window on secondary

Seems to be caused by a bug in Electron.

Related Electron issue: electron/electron#10862

Edit: There might be some kind of workaround out there, but for now I am marking this as blocked.

Electron apparently applies a minimum height of 38px for frameless windows (like the one we are using). Issue on Electron repo: electron/electron#23200.

This means that, if Windows taskbar is using small buttons, we can't make our window as thin as the taskbar.
For now, we handle that case by making sure the bottom of our window is aligned with the bottom of the screen (it then has a part that sticks out above the taskbar).

Some potentially related issues regarding Electron and frameless window size:

• electron/electron#22440
• electron/electron#22393