Giter Club home page Giter Club logo

django-images's People

Contributors

bogdal avatar chadsaun avatar kklimonda avatar overshard avatar patrys avatar zulupro avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

django-images's Issues

Replace PIL dependency with pillow

Pillow is described as a "friendly" fork of a PIL library maintained by the Plone community. PIL hasn't seen release for few years, and it's current version have an irritating bug where it doesn't detect system libraries on newer Debian and Ubuntu releases. Unfortunately even though Pillow provides a PIL package it doesn't actually satisfy the PIL dependency so it has to be changed or django-images installation overwrites a local pillow package.

Support input multipart

Hi,

Supporting input file with multipart attribute (html5) is not so hard to implement. Basicly, I have done it using

in view:

def form_valid(self, form):
  for image in self.request.FILES.getlist('image'):
    CustomImageModel(image=image).save()

in html:
add multipart attribute

It would be nice to have that feature out of the box. What do you think?

New tag?

Tag 0.4.3 still references south.db in migrations which is a nuisance.

Thumbnail unique_together constraint allows for duplicated entries

I got a report from someone who has managed to end up with two thumbnails for the same original image and size, but with different file names.

I've disjointed Image creation from thumbnail creation - image created at upload, thumbnails created when requested.

What I believe to have happened is that two concurrent requests for thumbnails have been made and Thumbnail.get_or_create_at_size executed image.thumbnail_set.create() twice.

Because unique constraint for Thumbnail is ("image", "size"), and because Django appends "_1" to file name when original name is taken, the second duplicated thumbnail row has been inserted - the same original_id and the same size but different image columns. Later when Image.get_by_size() was called MultipleObjectsReturned exception was raised.

I believe Thumbnail unique_together should be changed to ("original", "size"), coincidentally I believe it's a "more correct" constraint. Also, a migration should probably be created for South so existing applications can be fixed.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.